From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#26066: 26.0.50; vc-git-status gives wrong result Date: Mon, 24 Apr 2017 11:20:57 +0200 Message-ID: <874lxef9fq.fsf@linux-m68k.org> References: <9bf82bf1-fefa-ab84-bac1-cf748ae5ccfb@gmail.com> <87efxy59wx.fsf@users.sourceforge.net> <0d87686b-c7d2-deab-ebe4-ab1c8aa4faca@yandex.ru> <29d4a5ae-0ca0-3a86-6b9a-ab616803f39e@gmail.com> <4741bddf-9765-0d94-d0cd-b94e3e4914e1@yandex.ru> <8530cd03-0158-f198-9b14-ade983e1c7f4@gmail.com> <022c0e0a-e039-24ef-66ff-82bcedbacd93@yandex.ru> <505388da-e642-8c98-35c0-261d09ff13e1@yandex.ru> <1a23269d-1ead-1771-1afd-e2c9c5840cb4@gmail.com> <30d8b181-d869-de24-9c86-cc1dc6ec461b@gmail.com> <6ea0d89d-1a24-30fe-dd9a-26a0157a4eae@yandex.ru> <01922284-4265-6510-feee-dcc7301787ad@gmail.com> <7346fb37-f0b2-77dc-c227-cacfbd372775@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1493025741 4036 195.159.176.226 (24 Apr 2017 09:22:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Apr 2017 09:22:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cc: Noam Postavsky , 26066@debbugs.gnu.org, Stefan Monnier , Dmitry Gutov To: Jonathan Ganc Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 24 11:22:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2aCE-0000qC-TC for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Apr 2017 11:22:15 +0200 Original-Received: from localhost ([::1]:42889 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2aCI-0006Pg-UZ for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Apr 2017 05:22:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2aC6-0006NT-83 for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2017 05:22:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2aC2-000622-9I for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2017 05:22:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38894) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d2aC2-00061q-5q for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2017 05:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d2aC1-0004Cv-Ts for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2017 05:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Apr 2017 09:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26066 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 26066-submit@debbugs.gnu.org id=B26066.149302566516106 (code B ref 26066); Mon, 24 Apr 2017 09:22:01 +0000 Original-Received: (at 26066) by debbugs.gnu.org; 24 Apr 2017 09:21:05 +0000 Original-Received: from localhost ([127.0.0.1]:37092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2aB7-0004Bh-C0 for submit@debbugs.gnu.org; Mon, 24 Apr 2017 05:21:05 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.9]:52251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2aB5-0004BI-Fx for 26066@debbugs.gnu.org; Mon, 24 Apr 2017 05:21:04 -0400 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3wBLRv62Pcz1qqkV; Mon, 24 Apr 2017 11:20:59 +0200 (CEST) Original-Received: from localhost (dynscan01.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3wBLRv3kQCz3jgY2; Mon, 24 Apr 2017 11:20:59 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan01.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id cVx5o16Qs9RW; Mon, 24 Apr 2017 11:20:58 +0200 (CEST) X-Auth-Info: F7H3AtClu9XBpqgURNaa2UgeFfGcU5jw+Vo5HsGQ/nwLg/I+YSVatN6YzX8uh/OL Original-Received: from igel.home (ppp-88-217-7-231.dynamic.mnet-online.de [88.217.7.231]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 24 Apr 2017 11:20:58 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 1000) id D020B2C428F; Mon, 24 Apr 2017 11:20:57 +0200 (CEST) X-Yow: I just had my entire INTESTINAL TRACT coated with TEFLON! In-Reply-To: <7346fb37-f0b2-77dc-c227-cacfbd372775@gmail.com> (Jonathan Ganc's message of "Sun, 23 Apr 2017 20:50:38 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:131926 Archived-At: On Apr 23 2017, Jonathan Ganc wrote: > +(defun vc-git--git-status-to-vc-state (code-list) > + "Convert CODE-LIST to a vc status. > + > +Each element of CODE-LIST comes from the first two characters of > +a line returned by 'git status' and should be passed in the order > +given by 'git status'. > + > +\(It is necessary to allow CODE-LIST to be a list because > +sometimes git status returns multiple lines, e.g. for a file that > +is removed from the index but is present in the HEAD and working > +tree.) " I think the last paragraph could just be a code comment, given that you even put it in parens to de-emphasize it. Also, extra space at the end. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."