From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Marcin Borkowski Newsgroups: gmane.emacs.bugs Subject: bug#21072: Brave new mark-defun (and a testing tool) Date: Sun, 30 Apr 2017 16:49:06 +0200 Message-ID: <874lx6x865.fsf@jane> References: <87o9ydrzkr.fsf@mbork.pl> <87efyze00g.fsf@jane> <87bmu2eoji.fsf@jane> <87wpcpw61w.fsf@jane> <83o9xdghmc.fsf@gnu.org> <87o9wkoald.fsf@jane> <87a881ofsu.fsf@jane> <87k272wh8x.fsf@users.sourceforge.net> <871st4aal7.fsf@jane> <87tw5l7v26.fsf@jane> <877f2hs1nw.fsf@users.sourceforge.net> <87zifa9ce5.fsf@jane> <87shl0pbcg.fsf@users.sourceforge.net> <87shky9ez8.fsf@jane> <8737cyotmt.fsf@users.sourceforge.net> <87h919yf5g.fsf@jane> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1493563754 12623 195.159.176.226 (30 Apr 2017 14:49:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 30 Apr 2017 14:49:14 +0000 (UTC) User-Agent: mu4e 0.9.19; emacs 26.0.50 Cc: 21072@debbugs.gnu.org, Stefan Monnier To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 30 16:49:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d4q9t-000386-Gz for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Apr 2017 16:49:09 +0200 Original-Received: from localhost ([::1]:44890 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d4q9w-0006B9-3r for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Apr 2017 10:49:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d4q9p-0006B4-GA for bug-gnu-emacs@gnu.org; Sun, 30 Apr 2017 10:49:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d4q9m-0005lK-D7 for bug-gnu-emacs@gnu.org; Sun, 30 Apr 2017 10:49:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49702) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d4q9m-0005lG-9x for bug-gnu-emacs@gnu.org; Sun, 30 Apr 2017 10:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d4q9m-00010U-0y for bug-gnu-emacs@gnu.org; Sun, 30 Apr 2017 10:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Marcin Borkowski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Apr 2017 14:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21072-submit@debbugs.gnu.org id=B21072.14935637063827 (code B ref 21072); Sun, 30 Apr 2017 14:49:01 +0000 Original-Received: (at 21072) by debbugs.gnu.org; 30 Apr 2017 14:48:26 +0000 Original-Received: from localhost ([127.0.0.1]:47901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d4q9C-0000zf-Fp for submit@debbugs.gnu.org; Sun, 30 Apr 2017 10:48:26 -0400 Original-Received: from mail.mojserwer.eu ([195.110.48.8]:49858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d4q9B-0000zX-4w for 21072@debbugs.gnu.org; Sun, 30 Apr 2017 10:48:25 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 98BACE62DE; Sun, 30 Apr 2017 16:48:23 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Original-Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xxJoqdEQGjjw; Sun, 30 Apr 2017 16:48:18 +0200 (CEST) Original-Received: from localhost (gra4.internetdsl.tpnet.pl [83.3.182.4]) by mail.mojserwer.eu (Postfix) with ESMTPSA id B83A1E62BF; Sun, 30 Apr 2017 16:48:17 +0200 (CEST) In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132127 Archived-At: On 2017-04-27, at 23:48, Noam Postavsky wrote: > On Thu, Apr 27, 2017 at 12:43 PM, Marcin Borkowski wrote: >> >> On 2017-04-24, at 14:52, npostavs@users.sourceforge.net wrote: >> >>> Actually, now that I've applied this thing properly, I notice 2 test >>> failures in batch mode: >>> >>> 2 unexpected results: >>> FAILED mark-defun-arg-region-active >>> FAILED mark-defun-no-arg-region-active >>> >>> They pass when run in interactive mode (I haven't looked into why). >> >> Strangely enough, they also fail with my original code. Does anyone >> have any idea why that might be the case? > > Oh I see what it is, your test depends on `transient-mark-mode' being > enabled. With --batch, that defaults to nil. Should we be testing in > both modes or just explicitly set it to t? Good catch, thanks! I'll set it to t, since this functionality is intended to be used in t-t-m anyway. OTOH, I'm curious where it breaks with that disabled - I'll look into it now, I guess. > PS I noticed some problems with elisp-tests-with-temp-buffer while > looking at this, I pushed a fix to fix/bug-21072 [1: 04741f0]. > > 1: 2017-04-27 17:38:09 -0400 04741f02cca95147581e05cb49b54e6dbf8bed56 > Fix elisp-tests-with-temp-buffer compilation Thanks a lot, I'll take a look! Best, -- Marcin Borkowski