From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#27341: updated patch to fix docstring Date: Thu, 29 Jun 2017 20:54:02 -0400 Message-ID: <874luymh1x.fsf@users.sourceforge.net> References: <8760g1xxhw.fsf@utexas.edu> <8737b4grzq.fsf@utexas.edu> <8737aop2d9.fsf@users.sourceforge.net> <87lgoedf1t.fsf@utexas.edu> <87efu6nwa2.fsf@users.sourceforge.net> <878tkdy37e.fsf@utexas.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1498783993 24584 195.159.176.226 (30 Jun 2017 00:53:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 30 Jun 2017 00:53:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 27341@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 30 02:53:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQkBH-00067G-SB for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Jun 2017 02:53:08 +0200 Original-Received: from localhost ([::1]:41870 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQkBN-0007nL-6n for geb-bug-gnu-emacs@m.gmane.org; Thu, 29 Jun 2017 20:53:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQkBH-0007n2-Cf for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2017 20:53:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dQkBC-0007b5-GS for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2017 20:53:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42527) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dQkBC-0007aA-Di for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2017 20:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dQkBB-0000dd-UA for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2017 20:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Jun 2017 00:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27341-submit@debbugs.gnu.org id=B27341.14987839542418 (code B ref 27341); Fri, 30 Jun 2017 00:53:01 +0000 Original-Received: (at 27341) by debbugs.gnu.org; 30 Jun 2017 00:52:34 +0000 Original-Received: from localhost ([127.0.0.1]:45204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQkAj-0000cv-NR for submit@debbugs.gnu.org; Thu, 29 Jun 2017 20:52:33 -0400 Original-Received: from mail-io0-f171.google.com ([209.85.223.171]:36681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQkAh-0000cl-WF for 27341@debbugs.gnu.org; Thu, 29 Jun 2017 20:52:32 -0400 Original-Received: by mail-io0-f171.google.com with SMTP id z62so16388258ioi.3 for <27341@debbugs.gnu.org>; Thu, 29 Jun 2017 17:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/hJYBDsfx5HVorA1edeV3SLuWOLDSrxfWGLYlIwlToo=; b=J0AZHOX8oxuEuaLfL8bdYol9RPFclBd6gUHzecvgXsYgm16Ilvox99UnV7aIbNmJMP IFlifqaoTrOze3qE8JLDay+/vPaDZ3cK1CH4FrMd0jqNTFsIkrPWqDIsnHW8fq57M56e Njm0pJifqy/1B7TUGQtEpI4STI9vLxghVIoq1ZiA0HQHtNDNVKIJ93ijxyR3CLFudLd9 PL4vYvjeRBfjv6wPMBDXxGrXxVNhc8ZRB0vhvJDM8J93+e0a36pWRHE58gz8EgHjDjRR Tvq7ELQJks2/ASi4loOlv1RE4Folg2my3h7UvvNkKPNTva4RWhcOAA6TwIv482QUu2Hc pOZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=/hJYBDsfx5HVorA1edeV3SLuWOLDSrxfWGLYlIwlToo=; b=t+5FKLXW8A45kD4s4cxdrWOjukVG7rmOAhLSApFjWbLZ1d1EYJNCcWmwJOz2rroYa7 w5cCFd0GSqXmnV5KN86/Asc0EIWTe6y1sgeDArJzAevI2xNKnm3c5KhSVs+kq69pJoSU 8f0ezHB4Em0Y6K+25JxRtO3jU6w8WWqiLYKmgi1dKGjaCtqxYNzv1w4a2CS47ff1kLit Q7wjd8dkjP7Oid2tm6WT3H+oC/Gm08yUu4p889pzcJ+hSPRev0nyESy0EzRvPMBjY7AT A5s2rfmirOSjyePLzwEEICqkFVvGHDXJCwmq3mGjVB6kIE2UMinMyaVAH/bEf+Ow9UnR jZOw== X-Gm-Message-State: AKS2vOw7PhBGOJk+FOudaQxn0Ct+3Uxr0xQ8ENCIsDZ5+uSfHqYWdBEZ Wp68hlqJms82/4NT X-Received: by 10.107.32.197 with SMTP id g188mr21704199iog.146.1498783946300; Thu, 29 Jun 2017 17:52:26 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 66sm1344391itj.1.2017.06.29.17.52.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Jun 2017 17:52:25 -0700 (PDT) In-Reply-To: <878tkdy37e.fsf@utexas.edu> (Alex Branham's message of "Tue, 27 Jun 2017 15:23:17 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134043 Archived-At: Alex Branham writes: > Actually, we need to check (use-region-p) anyway in case the mark > hasn't been activated yet in the buffer: Oops, good catch, I hadn't thought of that. > Subject: [PATCH] eww-search-words prompt for query if region inactive or blank > > --- Could you add a ChangeLog entry to the commit message as described in CONTRIBUTE, please? > (defun eww-search-words (&optional beg end) > "Search the web for the text between BEG and END. > -See the `eww-search-prefix' variable for the search engine used." > + If region is active (and not whitespace), search the web for > + the text between BEG and END. Else, prompt the user for a search > + string. See the `eww-search-prefix' variable for the search > + engine used." Doc strings shouldn't be indented like that, and there should be a double space between sentences. > (interactive "r") > - (eww (buffer-substring beg end))) > + (if (use-region-p) > + (let ((region-string (buffer-substring beg end))) > + (if (not (string-match-p "\\`[ \n\t\r\v\f]*\\'" region-string)) > + (eww region-string))) > + (eww (read-string "Query: ")))) This silently does nothing if the region is active but just blanks, did you mean to fallback to querying in that case?