all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: npostavs@users.sourceforge.net
To: Alex Branham <branham@utexas.edu>
Cc: 27341@debbugs.gnu.org
Subject: bug#27341: updated patch to fix docstring
Date: Thu, 29 Jun 2017 20:54:02 -0400	[thread overview]
Message-ID: <874luymh1x.fsf@users.sourceforge.net> (raw)
In-Reply-To: <878tkdy37e.fsf@utexas.edu> (Alex Branham's message of "Tue, 27 Jun 2017 15:23:17 +0200")

Alex Branham <branham@utexas.edu> writes:

> Actually, we need to check (use-region-p) anyway in case the mark
> hasn't been activated yet in the buffer:

Oops, good catch, I hadn't thought of that.

> Subject: [PATCH] eww-search-words prompt for query if region inactive or blank
>
> ---

Could you add a ChangeLog entry to the commit message as described in
CONTRIBUTE, please?

>  (defun eww-search-words (&optional beg end)
>    "Search the web for the text between BEG and END.
> -See the `eww-search-prefix' variable for the search engine used."
> +    If region is active (and not whitespace), search the web for
> +  the text between BEG and END. Else, prompt the user for a search
> +  string. See the `eww-search-prefix' variable for the search
> +  engine used."

Doc strings shouldn't be indented like that, and there should be a
double space between sentences.

>    (interactive "r")
> -  (eww (buffer-substring beg end)))
> +  (if (use-region-p)
> +      (let ((region-string (buffer-substring beg end)))
> +        (if (not (string-match-p "\\`[ \n\t\r\v\f]*\\'" region-string))
> +            (eww region-string)))
> +    (eww (read-string "Query: "))))

This silently does nothing if the region is active but just blanks, did
you mean to fallback to querying in that case?






  reply	other threads:[~2017-06-30  0:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-12 11:21 bug#27341: eww-search-words should prompt if region inactive Alex Branham
2017-06-13  9:24 ` bug#27341: updated patch to fix docstring Alex Branham
2017-06-25 14:29   ` npostavs
2017-06-26 14:00     ` Alex Branham
2017-06-26 23:50       ` npostavs
2017-06-27  5:32         ` Alex Branham
2017-06-27 13:23           ` Alex Branham
2017-06-30  0:54             ` npostavs [this message]
2017-06-30  6:25               ` Alex Branham
2017-07-02 18:32             ` npostavs
2017-07-02 18:45               ` Alex Branham
2017-07-02 19:13                 ` npostavs
2017-07-02 19:25                   ` Alex Branham
2017-07-02 20:23                     ` npostavs
2017-06-27 14:40           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874luymh1x.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=27341@debbugs.gnu.org \
    --cc=branham@utexas.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.