From: Noam Postavsky <npostavs@users.sourceforge.net>
To: John Williams <jrw@pobox.com>
Cc: 28803@debbugs.gnu.org
Subject: bug#28803: [PATCH] Fixed compiler warnings for advised functions.
Date: Sat, 14 Oct 2017 19:47:15 -0400 [thread overview]
Message-ID: <874lr19trw.fsf@users.sourceforge.net> (raw)
In-Reply-To: <CAEdRJLBMV_O_JC8t=n3u6cv5PNi9XAbZewZUHQDTff-kzAFCyQ@mail.gmail.com> (John Williams's message of "Sat, 14 Oct 2017 15:55:21 -0700")
John Williams <jrw@pobox.com> writes:
> Oops. Is there anything that can be salvaged from my patch? Aside
> from fixing the bug, it also adds a unit test and refactors the logic
> for finding a function's argument list into a separate function
> that's not part of the help system.
We could add the test, it seems to be passing in emacs-26. Have you
assigned copyright to Emacs? (It's okay if you haven't, the patch is
small enough to go in regardless, we would just need to mark it.)
I don't think there's much need for moving the function argument
retrieval out of the help system.
(By the way, if you've spent some time looking at help-function-arglist,
perhaps you have some ideas about Bug#26270?
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26270)
next prev parent reply other threads:[~2017-10-14 23:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 23:02 bug#28803: [PATCH] Fixed compiler warnings for advised functions John Williams
2017-10-14 5:51 ` Noam Postavsky
[not found] ` <CAEdRJLCj0xMqWx5DNXALJQrJw7Z-nUYzXgHeB3Jh3zQd0zPB+A@mail.gmail.com>
[not found] ` <CAEdRJLCYmqcBajzDo-zHwuTg-mN=8APiZ6REYgYV5TAAu_E02A@mail.gmail.com>
2017-10-14 22:55 ` John Williams
2017-10-14 23:47 ` Noam Postavsky [this message]
2017-10-15 0:30 ` John Williams
2017-10-15 1:00 ` Noam Postavsky
2017-10-21 23:33 ` Noam Postavsky
2017-10-22 2:23 ` John Williams
2017-10-22 13:04 ` Noam Postavsky
2017-10-22 14:04 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lr19trw.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=28803@debbugs.gnu.org \
--cc=jrw@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.