From: Robert Pluim <rpluim@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: martin rudalics <rudalics@gmx.at>,
Emacs developers <emacs-devel@gnu.org>,
Kaushal Modi <kaushal.modi@gmail.com>
Subject: Re: emacs-26 build breaking on RHEL 6.6 GTK2
Date: Wed, 24 Jan 2018 19:04:59 +0100 [thread overview]
Message-ID: <874lnbjfp0.fsf@gmail.com> (raw)
In-Reply-To: <ja4lnbkv4m.fsf@fencepost.gnu.org> (Glenn Morris's message of "Wed, 24 Jan 2018 12:46:17 -0500")
[-- Attachment #1: Type: text/plain, Size: 298 bytes --]
Glenn Morris <rgm@gnu.org> writes:
> And --with-x-toolkit=lucid (on rhel7):
>
> xterm.o: In function `x_set_offset':
> xterm.c:10313: undefined reference to `xg_get_scale'
*sigh* too many combinations to test. [1]
Robert
Footnotes:
[1] Did we ever get anywhere on a CI setup for emacs?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-gtk-scaling-changes.patch --]
[-- Type: text/x-diff, Size: 692 bytes --]
From 3f0866efb84902b89b56e3897471e646fe11b8d9 Mon Sep 17 00:00:00 2001
From: Robert Pluim <rpluim@gmail.com>
Date: Wed, 24 Jan 2018 19:01:52 +0100
Subject: [PATCH] Fix gtk scaling changes
* src/xterm.c (x_set_offset): Only call xg_get_scale if using GTK.
---
src/xterm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/xterm.c b/src/xterm.c
index f05ac6147e..364a8a8db0 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -10310,7 +10310,9 @@ void
x_set_offset (struct frame *f, register int xoff, register int yoff, int change_gravity)
{
int modified_top, modified_left;
+#ifdef USE_GTK
int scale = xg_get_scale (f);
+#endif
if (change_gravity > 0)
{
--
2.16.0.rc1
next prev parent reply other threads:[~2018-01-24 18:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 15:48 emacs-26 build breaking on RHEL 6.6 GTK2 Kaushal Modi
2018-01-24 15:53 ` Kaushal Modi
2018-02-20 11:04 ` Robert Pluim
2018-02-20 15:22 ` Kaushal Modi
2018-02-20 16:21 ` Robert Pluim
2018-01-24 16:12 ` Robert Pluim
2018-01-24 17:28 ` Kaushal Modi
2018-01-24 17:46 ` Glenn Morris
2018-01-24 18:04 ` Robert Pluim [this message]
2018-01-24 18:26 ` Glenn Morris
2018-01-24 18:39 ` Robert Pluim
2018-01-24 18:43 ` Noam Postavsky
2018-01-24 18:32 ` martin rudalics
2018-01-24 18:41 ` Robert Pluim
2018-01-24 18:47 ` martin rudalics
2018-01-24 18:52 ` Robert Pluim
2018-01-24 19:16 ` martin rudalics
2018-01-24 19:22 ` Robert Pluim
2018-01-24 20:10 ` Eli Zaretskii
2018-01-24 20:19 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lnbjfp0.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=kaushal.modi@gmail.com \
--cc=rgm@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.