From: Matthew Leach <matthew@mattleach.net>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 24218@debbugs.gnu.org, lomov.vl@gmail.com
Subject: bug#24218: 25.1.50; server-name, server-socket-dir and daemon start through, systemd socket
Date: Mon, 12 Feb 2018 14:24:06 +0000 [thread overview]
Message-ID: <874lmmz3p5.fsf@mattleach.net> (raw)
In-Reply-To: <52b062c7-adb2-c8ad-dc57-b5af849d5b18@cs.ucla.edu> (Paul Eggert's message of "Sat, 10 Feb 2018 08:07:47 -0800")
Paul Eggert <eggert@cs.ucla.edu> writes:
> Matthew Leach wrote:
>> Paul Eggert <eggert@cs.ucla.edu> writes:
>>
>>> On 01/09/2018 11:53 AM, Matthew Leach wrote:
>>>> May I suggest `internal--daemon-sockname'?
>>>
>>> Yes, that sounds good. Can you prepare a patch along those lines?
>>
>> Sure, please see the attached patch series.
>
> Thanks, but aren't there some more places where the variable needs to
> be renamed to internal--daemon-sockname?
Oops - I missed an additional `-' on the variable name.
> Also, I would rather not document it in the Emacs Lisp reference
> manual, as it is an internal detail that outside code shouldn't depend
> on.
That sounds fine; I wasn't aware that internal variables shouldn't be
documented in the Emacs List Reference Manual.
> Proposed further patch attached (it's the last of the attachments,
> which contain all the patches for this bug).
This last patch looks good to me.
Thanks,
--
Matt
next prev parent reply other threads:[~2018-02-12 14:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 16:35 bug#24218: 25.1.50; server-name, server-socket-dir and daemon start through systemd socket Vladimir Lomov
2016-08-15 2:25 ` Paul Eggert
2018-01-07 21:55 ` bug#24218: 25.1.50; server-name, server-socket-dir and daemon start through, " Paul Eggert
2018-01-08 3:50 ` Eli Zaretskii
2018-01-08 4:24 ` Paul Eggert
2018-01-08 18:33 ` Eli Zaretskii
2018-01-08 18:42 ` Paul Eggert
2018-01-08 19:14 ` Eli Zaretskii
2018-01-08 19:23 ` Paul Eggert
2018-01-09 19:53 ` Matthew Leach
2018-01-24 23:00 ` Paul Eggert
2018-01-25 19:34 ` Matthew Leach
2018-02-10 16:07 ` Paul Eggert
2018-02-12 14:24 ` Matthew Leach [this message]
2018-02-12 20:58 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lmmz3p5.fsf@mattleach.net \
--to=matthew@mattleach.net \
--cc=24218@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=lomov.vl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.