From: phillip.lord@russet.org.uk (Phillip Lord)
To: 30745@debbugs.gnu.org
Subject: bug#30745: 26.0.91; ert should macros nest strangely
Date: Wed, 07 Mar 2018 21:34:22 +0000 [thread overview]
Message-ID: <874llr4lk1.fsf@russet.org.uk> (raw)
ert should macros seem to behave strangely when nested.
Consider the following reproduction:
(require 'cl-lib)
(require 'ert)
(princ
(cl-cdadr
(ert-test-result-with-condition-condition
(ert-run-test
(make-ert-test
:body
(lambda () (should (eq 1 2))))))))
(princ "\nSecond test\n")
(princ
(should
(equal
(cl-cdadr
(ert-test-result-with-condition-condition
(ert-run-test
(make-ert-test
:body
(lambda () (should (eq 1 2)))))))
'(:form (eq 1 2) :value nil))))
(princ "\n")
In Emacs-25 the following behaviour is seen when running this in batch.
~/src/git/emacs-git/emacs-25$ ./src/emacs --batch -l temp.el
(:form (eq 1 2) :value nil)
Second test
t
In Emacs-26, however, we get a different behaviour:
~/src/git/emacs-git/emacs-26$ ./phil_emacs.sh
(:form (eq 1 2) :value nil)
Second test
Test failed: ((should (equal (cl-cdadr (ert-test-result-with-condition-condition (ert-run-test (make-ert-test :body (lambda nil (should (eq 1 2))))))) (quote (:form (eq 1 2) :value nil)))) :form (equal nil (:form (eq 1 2) :value nil)) :value nil :explanation (different-types nil (:form (eq 1 2) :value nil)))
So, although, the return type of this lot:
(cl-cdadr
(ert-test-result-with-condition-condition
(ert-run-test
(make-ert-test
:body
(lambda () (should (eq 1 2))))))))
remains the same between Emacs-25 and Emacs-26, a test for this breaks.
This regression is caused by:
commit 054c198c120c1f01a8ff753892d52710b740acc6
found by bisection. The regression continues on master.
I will try and find a simpler reproduction.
next reply other threads:[~2018-03-07 21:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 21:34 Phillip Lord [this message]
2018-03-07 22:24 ` bug#30745: 26.0.91; ert should macros nest strangely Phillip Lord
2018-03-08 14:49 ` bug#24402: " Phillip Lord
2018-03-08 0:12 ` Noam Postavsky
2018-03-08 8:54 ` Phillip Lord
2018-08-15 0:47 ` Noam Postavsky
2019-06-24 18:54 ` Lars Ingebrigtsen
2019-06-24 22:53 ` Noam Postavsky
2019-06-28 3:06 ` Noam Postavsky
2020-11-29 10:35 ` Philipp Stephani
2021-07-22 13:13 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874llr4lk1.fsf@russet.org.uk \
--to=phillip.lord@russet.org.uk \
--cc=30745@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.