all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Nicolas Petton <nicolas@petton.fr>
Cc: Damien Cassou <damien@cassou.me>, 30444@debbugs.gnu.org
Subject: bug#30444: 26.0.90; browse-url-emacs sets default-directory to "https://"
Date: Wed, 14 Mar 2018 17:09:22 +0100	[thread overview]
Message-ID: <874llitz9p.fsf@gmx.de> (raw)
In-Reply-To: <87tvtj8yrd.fsf@petton.fr> (Nicolas Petton's message of "Tue, 13 Mar 2018 22:13:42 +0100")

Nicolas Petton <nicolas@petton.fr> writes:

Hi Nico,

> Here's a first tentative.  It's probably naive though, as there might be
> some corner cases I didn't think of and I'm new to file-handlers.

I haven't tested thoroughly, but your tests look OK.

> +    (should (equal (file-name-directory "https://foo.org")
> +                   "https://foo.org/"))))

This is OK, but I would add also

    (should (equal (file-name-directory "https://foo.org/")
                   "https://foo.org/"))))

Maybe you could add also negative tests, for example for
(file-name-directory "not-a-uri://foo.org")

Best regards, Michael.





  reply	other threads:[~2018-03-14 16:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-13 12:52 bug#30444: 26.0.90; browse-url-emacs sets default-directory to "https://" Damien Cassou
2018-02-13 15:15 ` Nicolas Petton
2018-02-13 15:44   ` Damien Cassou
2018-02-13 16:27     ` Nicolas Petton
2018-03-10 10:46 ` Eli Zaretskii
2018-03-10 13:11   ` Michael Albinus
2018-03-12  9:18     ` Nicolas Petton
2018-03-12  9:42       ` Michael Albinus
2018-03-12 10:45         ` Nicolas Petton
2018-03-13 20:34         ` Nicolas Petton
2018-03-13 20:45           ` Robert Pluim
2018-03-13 21:13         ` Nicolas Petton
2018-03-14 16:09           ` Michael Albinus [this message]
2018-03-16 21:02             ` Nicolas Petton
2018-03-18  8:49               ` Michael Albinus
2018-03-18 19:43                 ` Nicolas Petton
2018-03-18 19:48                 ` Nicolas Petton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874llitz9p.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=30444@debbugs.gnu.org \
    --cc=damien@cassou.me \
    --cc=nicolas@petton.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.