From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#30812: Perl syntax highlighting regression in fix for #27613? (feecb66b6fe41c977b8e11b5f2d419c9544f42de) Date: Tue, 20 Mar 2018 20:26:39 -0400 Message-ID: <874llatgsg.fsf@gmail.com> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1521591912 14088 195.159.176.226 (21 Mar 2018 00:25:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Mar 2018 00:25:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 30812@debbugs.gnu.org, jeffersoncarpenter2@gmail.com To: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 21 01:25:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyRYx-0003YY-56 for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Mar 2018 01:25:07 +0100 Original-Received: from localhost ([::1]:52230 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyRb0-0006ZP-77 for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Mar 2018 20:27:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyRar-0006Xu-Oa for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2018 20:27:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyRao-00006k-K3 for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2018 20:27:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36543) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eyRao-00006W-EP for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2018 20:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eyRao-0008TB-2K for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2018 20:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Mar 2018 00:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30812 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30812-submit@debbugs.gnu.org id=B30812.152159201132538 (code B ref 30812); Wed, 21 Mar 2018 00:27:02 +0000 Original-Received: (at 30812) by debbugs.gnu.org; 21 Mar 2018 00:26:51 +0000 Original-Received: from localhost ([127.0.0.1]:44440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyRac-0008Sf-RA for submit@debbugs.gnu.org; Tue, 20 Mar 2018 20:26:51 -0400 Original-Received: from mail-io0-f180.google.com ([209.85.223.180]:36528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyRaZ-0008SM-Im; Tue, 20 Mar 2018 20:26:48 -0400 Original-Received: by mail-io0-f180.google.com with SMTP id o4so4562111iod.3; Tue, 20 Mar 2018 17:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=PEE25MI5hvGepB3nJh5YuxfW6fZF3QAyXU+5akxjk3A=; b=udTOfD4aO8fPgY6pjk6Q9zDOHKJNdS3aQKr05ViqpJUsrrLKJSqZNsT7GoCLf4DYQR kw4ZMy8XgFcAm1JbVl3GkzDtIwQEmbridWKBGNd/qsk4D0NMezIktcXzWaOFKvRPdFgi u+H8F25Iqy6/vSeG3DcuYkmcYHICL5bAmTxzf/NkVH5Ujo69ItVGyawq4AR0mt7P2eYe 3Gwk/848yjZGXPvgl74gEj3ozfjlhixwrWLnZMXNuOQDFew3AWgDi8OL4KQBLqMXJcwc F7VoJOfvRqU4fXOUMe29GJqtDCpt+IU1E/MqyfK1RCZ3yAzhyeKWrxgJUz6f2IoNdiKB V4DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=PEE25MI5hvGepB3nJh5YuxfW6fZF3QAyXU+5akxjk3A=; b=U9fw8FEkG73L721RiFae9pKyBfcH/CzMKKbs85fYybYf+/7ggMupggc9HG3jYflNlF 9UmlQkRuXIDnJfcmlVX+20sZfvDZKm80EL1ceuKZ7Q9HEKTWzm4YrzcAwok9UpvyoAlk BmOMXWWify/ac145ZXybQgDEiUcFB3FQhUGyiR+js44YwdJot1k4j16ILG2qC4zXxZIn WC2XlL54Gtm5L9eaYSdHhHt9W6bnx+bSZ4SX4sS5UoAfteg5J7CCSiWkfCL8w36jnuqk lDQgcu/RoHtTpnsfA/QnJo1+A1DY8ENNuqUNp5OouJ0fKNCwGT3PeNFQStpM3/ivVTmh W56w== X-Gm-Message-State: AElRT7F/x/G31b5SwL5tbVhjCbmLN0wf5KD8VI3aT/u5XkKPEVYN8hxQ 5hxsC7X0VEYViiVREgcYFnvbcw== X-Google-Smtp-Source: AG47ELsEcfiG83RsxNEIID3sglAwfUNKGSsijjsE4Q+iBbxJyhIenk4y0E0mOvmU6b417OTCIqiJbA== X-Received: by 10.107.144.197 with SMTP id s188mr19661606iod.147.1521592001943; Tue, 20 Mar 2018 17:26:41 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 12-v6sm2252618itm.0.2018.03.20.17.26.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Mar 2018 17:26:41 -0700 (PDT) In-Reply-To: ("=?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel"'s message of "Tue, 13 Mar 2018 19:14:56 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144477 Archived-At: unarchive 27613 notfixed 27613 26.1 quit Cl=C3=A9ment Pit-Claudel writes: > I think the following commit was a bit too enthusiastic, as variables > like @temp are now highlighted in font-lock-type-face. I've reverted this from emacs-26 [1: f8cad16bb3]. > - ("\\<\\(local\\|my\\)\\>" . font-lock-type-face) > + ;; Fontify declarators and prefixes as types. > + ("\\<\\(anon\\|argument\\|has\\|local\\|my\\|our\\|state\\|supersed= e\\)\\>" . font-lock-type-face) ; declarators > + ("\\<\\(let\\|temp\\)\\>" . font-lock-type-face) ; prefixes > Am I missing something? (I don't speak Perl, so I noticed this in a regre= ssion test) I missed this in the originating thread, but according to what I'm getting from web searches, most of those keywords are perl 6 specific. I think perl-mode shouldn't support them. [1: f8cad16bb3]: 2018-03-20 20:14:40 -0400 Revert "Support all perl variable declarators and prefixes" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3Df8cad16bb3272a80= 69b3008019f9d18516aef1a5>