From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#30908: woman2-roff-buffer fails to restore set-text-properties, etc. on error Date: Fri, 23 Mar 2018 06:20:57 -0400 Message-ID: <874ll7rt2u.fsf@gmail.com> References: <87o9jg568u.fsf@violet.siamics.net> <87bmffsjf2.fsf@gmail.com> <87fu4r5va6.fsf@violet.siamics.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1521800417 23488 195.159.176.226 (23 Mar 2018 10:20:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Mar 2018 10:20:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 30908@debbugs.gnu.org To: Ivan Shmakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 23 11:20:13 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezJnv-0005zo-SC for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Mar 2018 11:20:11 +0100 Original-Received: from localhost ([::1]:37014 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezJpz-0006WT-6H for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Mar 2018 06:22:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezJpl-0006Sm-IJ for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2018 06:22:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezJpi-0001CV-Dl for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2018 06:22:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40794) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ezJpi-0001CP-8U for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2018 06:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ezJpi-0003XC-0V for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2018 06:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Mar 2018 10:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30908 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30908-submit@debbugs.gnu.org id=B30908.152180046813522 (code B ref 30908); Fri, 23 Mar 2018 10:22:01 +0000 Original-Received: (at 30908) by debbugs.gnu.org; 23 Mar 2018 10:21:08 +0000 Original-Received: from localhost ([127.0.0.1]:48691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezJop-0003W2-VT for submit@debbugs.gnu.org; Fri, 23 Mar 2018 06:21:08 -0400 Original-Received: from mail-io0-f170.google.com ([209.85.223.170]:44239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezJon-0003V2-HZ for 30908@debbugs.gnu.org; Fri, 23 Mar 2018 06:21:06 -0400 Original-Received: by mail-io0-f170.google.com with SMTP id h23so14529061iob.11 for <30908@debbugs.gnu.org>; Fri, 23 Mar 2018 03:21:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=lGsB8cITK6BkLT44kWKoDtmNCzzT66qJHIWCdp20Vck=; b=l8WxnRmPV8c4bVBu6VNj4fUalrvW1euGkVfWILsoI3lz+l0XIjX5wwbPbQsQJX53zM SiJeVBtMkI2MEtVS72LyL1N1jvNIV5cbsb6J0qour+T5UNhl6Cz0RXLWZWQhL+F+eK/b bGq0KS0vs2RaorllVsm6Dmg4ILObCX1+R/bLnmXZvwnhZWF9QIH5hEkh+z5qmEgeSFB0 jM37flHkRd7/e+FZi10s9X/7MvCoao4zn3/igskW9gcsk37lzI+XXREqWoWyg9MWMjOE Dx9pcWOolm+ECVFU3aY3DJN7kEA3H7XU6yALDsUiOuD3exqWfdSC2ogGp7R8N5xxyyMB EBwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=lGsB8cITK6BkLT44kWKoDtmNCzzT66qJHIWCdp20Vck=; b=aDRFirtB2TsGc030WxA2vMcxmsaaGsKP2RH4YNkwkldkKGDSPazZmXfUiRSXtMchdB H+I1AWh9qnQHnm9ceLUEjx2RCYofHkWSiaJDb0qfVCZpBZcgGZwyIA1KEuDrXxuT/HY/ m3JfuVRPza7P3xUrJrO9JNNIfAqTf593dUBq1DDTiWGQJQUNSnfBBzAxeyJuyt3nFIrP 6q/zPZdqib63EIZPbFFahj1T3guNZNtHU7ySJVXsa9CBA2gDjtNPxewCX4zuRbPcjcAV cCemlphGdufAPsmluWh1SaUMkUxLFWSYndMHP6zJw4yGyLU8/VRGY8ejzP+aKD054LKu uhMA== X-Gm-Message-State: AElRT7EHMPp1FETFrammljbCGaaBpD0/bBckPlvIFpo/ouFsHN16spoM QpfSBEmhnQaUixeqRHyMx3CaIw== X-Google-Smtp-Source: AG47ELtaZfJjQa0GapzQda5JioH2reEM8hxAeB2otuPDVzEaC/f1TVlfXR3XYw1ZCkV/CKTCgsjvLw== X-Received: by 10.107.55.133 with SMTP id e127mr27872248ioa.138.1521800459657; Fri, 23 Mar 2018 03:20:59 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id q99sm6381530ioi.40.2018.03.23.03.20.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Mar 2018 03:20:58 -0700 (PDT) In-Reply-To: <87fu4r5va6.fsf@violet.siamics.net> (Ivan Shmakov's message of "Fri, 23 Mar 2018 03:24:17 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144552 Archived-At: Ivan Shmakov writes: > > Shouldn=E2=80=99t this rather be combined into the existing unwind-pro= tect > > around the while? > > Due to the (not (eobp)) guard, I=E2=80=99ve assumed that the > woman2-format-paragraphs call in the =E2=80=98unwind=E2=80=99 branch is = for some > sort of fallback processing (in the case the while loop fails.) Hmm, looking at this again, I'm not sure. That is, it's clearly fallback processing in case the loop ends before going through the whole buffer. But does it also make sense as fallback processing when some kind of error was signaled in the loop? I don't know.