all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@gmail.com>
To: Ivan Shmakov <ivan@siamics.net>
Cc: 30908@debbugs.gnu.org
Subject: bug#30908: woman2-roff-buffer fails to restore set-text-properties, etc. on error
Date: Fri, 23 Mar 2018 06:20:57 -0400	[thread overview]
Message-ID: <874ll7rt2u.fsf@gmail.com> (raw)
In-Reply-To: <87fu4r5va6.fsf@violet.siamics.net> (Ivan Shmakov's message of "Fri, 23 Mar 2018 03:24:17 +0000")

Ivan Shmakov <ivan@siamics.net> writes:

>  > Shouldn’t this rather be combined into the existing unwind-protect
>  > around the while?
>
> 	Due to the (not (eobp)) guard, I’ve assumed that the
> 	woman2-format-paragraphs call in the ‘unwind’ branch is for some
> 	sort of fallback processing (in the case the while loop fails.)

Hmm, looking at this again, I'm not sure.  That is, it's clearly
fallback processing in case the loop ends before going through the whole
buffer.  But does it also make sense as fallback processing when some
kind of error was signaled in the loop?  I don't know.






  reply	other threads:[~2018-03-23 10:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-22 18:12 bug#30908: woman2-roff-buffer fails to restore set-text-properties, etc. on error Ivan Shmakov
2018-03-23  0:52 ` Noam Postavsky
2018-03-23  3:24   ` Ivan Shmakov
2018-03-23 10:20     ` Noam Postavsky [this message]
2018-04-26 12:01       ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ll7rt2u.fsf@gmail.com \
    --to=npostavs@gmail.com \
    --cc=30908@debbugs.gnu.org \
    --cc=ivan@siamics.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.