From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#30244: 25.2.50; Killing sql mode buffer results in error Date: Tue, 17 Apr 2018 22:08:40 +0200 Message-ID: <874lk9iojb.fsf@mouse.gnus.org> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1523995630 3767 195.159.176.226 (17 Apr 2018 20:07:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 17 Apr 2018 20:07:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 30244@debbugs.gnu.org To: Allen Li Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 17 22:07:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8Wsa-0000ro-WD for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Apr 2018 22:07:05 +0200 Original-Received: from localhost ([::1]:60048 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8Wuh-0008Po-NW for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Apr 2018 16:09:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8WuX-0008N8-BQ for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 16:09:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8WuU-0002id-4Z for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 16:09:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50023) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8WuT-0002hf-Vh for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 16:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f8WuT-0006gH-On for bug-gnu-emacs@gnu.org; Tue, 17 Apr 2018 16:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Apr 2018 20:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30244 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30244-submit@debbugs.gnu.org id=B30244.152399573225666 (code B ref 30244); Tue, 17 Apr 2018 20:09:01 +0000 Original-Received: (at 30244) by debbugs.gnu.org; 17 Apr 2018 20:08:52 +0000 Original-Received: from localhost ([127.0.0.1]:57920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8WuK-0006fu-CT for submit@debbugs.gnu.org; Tue, 17 Apr 2018 16:08:52 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:38308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8WuJ-0006fm-2b for 30244@debbugs.gnu.org; Tue, 17 Apr 2018 16:08:51 -0400 Original-Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f8WuG-0003oH-0v; Tue, 17 Apr 2018 22:08:50 +0200 Original-Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f8Wu8-0002fU-Uq; Tue, 17 Apr 2018 22:08:40 +0200 In-Reply-To: (Allen Li's message of "Wed, 24 Jan 2018 16:28:07 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145517 Archived-At: Allen Li writes: > To reproduce (need a mysql server handy): > > M-x toggle-debug-on-error RET > M-x sql-mysql RET > C-x k RET yes RET > > Yields error: > > Debugger entered--Lisp error: (error "Selecting deleted buffer") > sql-stop(# "hangup\n") I don't use sql-mode, so I can't test this. Does the following trivial patch work fix the bug for you? diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el index f907a01d8c..ebbef8d89e 100644 --- a/lisp/progmodes/sql.el +++ b/lisp/progmodes/sql.el @@ -4031,15 +4031,16 @@ sql-stop This function is a sentinel watching the SQL interpreter process. Sentinels will always get the two parameters PROCESS and EVENT." - (with-current-buffer (process-buffer process) - (let - ((comint-input-ring-separator sql-input-ring-separator) - (comint-input-ring-file-name sql-input-ring-file-name)) - (comint-write-input-ring)) - - (if (not buffer-read-only) - (insert (format "\nProcess %s %s\n" process event)) - (message "Process %s %s" process event)))) + (when (buffer-live-p (process-buffer process)) + (with-current-buffer (process-buffer process) + (let + ((comint-input-ring-separator sql-input-ring-separator) + (comint-input-ring-file-name sql-input-ring-file-name)) + (comint-write-input-ring)) + + (if (not buffer-read-only) + (insert (format "\nProcess %s %s\n" process event)) + (message "Process %s %s" process event))))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no