From: Noam Postavsky <npostavs@gmail.com>
To: 31211@debbugs.gnu.org
Subject: bug#31211: 27.0.50; Pruning of command-history in command-execute is off by one
Date: Sun, 29 Apr 2018 18:43:02 -0400 [thread overview]
Message-ID: <874ljtprbd.fsf@gmail.com> (raw)
In-Reply-To: <87po2hhjov.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 29 Apr 2018 20:54:56 +0100")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> Is there any reason why we can't use add-to-history in places like
> Fcall_interactively in src/callint.c and read_minibuf in src/minibuf.c,
> rather than duplicating its logic and falling into off-by-one traps?
Sometimes there can be bootstrapping problems (e.g., the C code tries to
call Lisp code that hasn't been loaded yet). In this case, I don't
think call-interactively should be needed during bootstrap, so it's
probably fine.
> I attach a patch which delegates to add-to-history in various such
> places, on the assumption this is kosher. Please let me know whether
> something like this would be acceptable and/or how it can made so.
>
> The second attachment comprises the same minor lisp/simple.el touch-ups
> as in my last email.
Thanks, I'll push to master in a few days assuming there are no
objections.
next prev parent reply other threads:[~2018-04-29 22:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 18:36 bug#31211: 27.0.50; Pruning of command-history in command-execute is off by one Basil L. Contovounesios
2018-04-18 18:43 ` Basil L. Contovounesios
2018-04-18 18:52 ` Basil L. Contovounesios
2018-04-20 12:53 ` Noam Postavsky
2018-04-29 19:54 ` Basil L. Contovounesios
2018-04-29 22:43 ` Noam Postavsky [this message]
2018-04-30 0:51 ` Basil L. Contovounesios
2018-05-03 0:37 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ljtprbd.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=31211@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.