From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Welsh Duggan Newsgroups: gmane.emacs.bugs Subject: bug#17675: 24.4.50; *gud* buffer keeps on getting buried Date: Sun, 20 May 2018 20:18:06 -0400 Message-ID: <874lj1c14x.fsf@md5i.com> References: <87d2eqyqd9.fsf@maru2.md5i.com> <538DF2FC.8020908@gmx.at> <877g4xzebb.fsf@maru2.md5i.com> <538EBFB3.4010202@gmx.at> <87y4xcyl80.fsf@maru2.md5i.com> <538F3259.5080507@gmx.at> <87tx80xjtx.fsf@maru2.md5i.com> <539020D0.6020208@gmx.at> <878uj15wgc.fsf@maru2.md5i.com> <87ppcd4hqa.fsf@maru2.md5i.com> <87lhn14hkr.fsf@maru2.md5i.com> <87d0xpj2tr.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1526861832 23498 195.159.176.226 (21 May 2018 00:17:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 21 May 2018 00:17:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Noam Postavsky To: 17675@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 21 02:17:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKYVf-00061J-8c for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 May 2018 02:17:07 +0200 Original-Received: from localhost ([::1]:48124 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKYXm-0000oG-9N for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 May 2018 20:19:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKYXb-0000nW-EE for bug-gnu-emacs@gnu.org; Sun, 20 May 2018 20:19:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKYXW-0007Bo-PC for bug-gnu-emacs@gnu.org; Sun, 20 May 2018 20:19:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34373) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fKYXW-0007Be-Jn for bug-gnu-emacs@gnu.org; Sun, 20 May 2018 20:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fKYXW-0007kE-5T for bug-gnu-emacs@gnu.org; Sun, 20 May 2018 20:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Welsh Duggan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 May 2018 00:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17675 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17675-submit@debbugs.gnu.org id=B17675.152686188929669 (code B ref 17675); Mon, 21 May 2018 00:19:02 +0000 Original-Received: (at 17675) by debbugs.gnu.org; 21 May 2018 00:18:09 +0000 Original-Received: from localhost ([127.0.0.1]:42265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKYWf-0007iT-5l for submit@debbugs.gnu.org; Sun, 20 May 2018 20:18:09 -0400 Original-Received: from md5i.com ([75.151.244.229]:52442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKYWd-0007iL-OR for 17675@debbugs.gnu.org; Sun, 20 May 2018 20:18:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=md5i.com; s=dkim; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=57N42MewRuo0V6HjNgmOED5w94b4uIYblYHoiyA886s=; b=UocSy9vsA3MUqB9rYlIRsQ4nhC Ae82TcnIx+0Hsn8LVmso2y3t3NJwOlS4S6wGmMmN9U/dezD2MnHgbjhfzsrS/T5x9GJ5UsZie53Ij VuneU/GUBNqURapLhoTCwIEpA; Original-Received: from md5i by md5i.com with local (Exim 4.91) (envelope-from ) id 1fKYWc-00029t-Oa; Sun, 20 May 2018 20:18:06 -0400 In-Reply-To: <87d0xpj2tr.fsf@gmail.com> (Noam Postavsky's message of "Sun, 20 May 2018 19:59:44 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146332 Archived-At: Noam Postavsky writes: > Michael Welsh Duggan writes: > >> And one more time, this time incorporating your suggestion more >> completely. >> >> diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el >> index 24d5469..71dc574 100644 >> --- a/lisp/progmodes/gud.el >> +++ b/lisp/progmodes/gud.el >> @@ -2603,7 +2603,12 @@ comint mode, which see." >> file-subst))) >> (filepart (and file-word (concat "-" (file-name-nondirectory file)))) >> (existing-buffer (get-buffer (concat "*gud" filepart "*")))) >> - (switch-to-buffer (concat "*gud" filepart "*")) >> + (select-window > > Is this select-window call neeeded? I think so, since `display-buffer' does not necessarily select the window in which it displays the buffer, whereas the `switch-to-buffer' it is replacing displays the buffer in the currently selected window. Certainly in this case you want the "*gud*" buffer to be the selected buffer after this command. This bug was actually "fixed" using my original suggestion of binding `inhibit-same-window' to t, but I am not qualified to say which solution is "more correct." See . >> + (display-buffer >> + (get-buffer-create (concat "*gud" filepart "*")) >> + '(display-buffer-reuse-window >> + display-buffer-in-previous-window >> + display-buffer-same-window display-buffer-pop-up-window))) >> (when (and existing-buffer (get-buffer-process existing-buffer)) >> (error "This program is already being debugged")) >> ;; Set the dir, in case the buffer already existed with a different dir. > > Martin, I see the switch-to-buffer is still present in master now, > should it be fixed? -- Michael Welsh Duggan (md5i@md5i.com)