From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31715: cl-incf and cl-decf error out when passed a nil-valued variable as 'offset' Date: Mon, 04 Jun 2018 18:58:01 -0400 Message-ID: <874lii88hy.fsf@gmail.com> References: <1dff07f6-8da4-4e4c-a700-0bc39d6f2aa6@live.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1528153028 13994 195.159.176.226 (4 Jun 2018 22:57:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 4 Jun 2018 22:57:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 31715@debbugs.gnu.org To: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 05 00:57:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPyPP-0003TM-1n for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Jun 2018 00:57:03 +0200 Original-Received: from localhost ([::1]:42260 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPyRV-0001mX-VF for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jun 2018 18:59:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPyRO-0001mG-VJ for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 18:59:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPyRL-0004Ho-0n for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 18:59:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54042) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fPyRK-0004Ha-Rv for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 18:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fPyRK-00032q-7m for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 18:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jun 2018 22:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31715 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31715-submit@debbugs.gnu.org id=B31715.152815309111638 (code B ref 31715); Mon, 04 Jun 2018 22:59:02 +0000 Original-Received: (at 31715) by debbugs.gnu.org; 4 Jun 2018 22:58:11 +0000 Original-Received: from localhost ([127.0.0.1]:33706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPyQV-00031e-6r for submit@debbugs.gnu.org; Mon, 04 Jun 2018 18:58:11 -0400 Original-Received: from mail-io0-f170.google.com ([209.85.223.170]:37601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPyQT-00031Q-QL for 31715@debbugs.gnu.org; Mon, 04 Jun 2018 18:58:10 -0400 Original-Received: by mail-io0-f170.google.com with SMTP id s26-v6so986819ioj.4 for <31715@debbugs.gnu.org>; Mon, 04 Jun 2018 15:58:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=opYVatSslr8WQkpUTuzfg2/jmb+MHi02RVB8L0MaPpw=; b=SXsMLc7Af9wT6GTTZoF58io86fTUbL6M6aGAUdFgag3j410KPQXVj6GvpgG555d+8Q MTIrLXry9Ea44M1u2HMMBpD0BS3AlOWy9NYBvBHDxtMKm0W84S0QvdT1q8PmZ921YczZ CitsnfzA/7A0V7/1dRds3ZhTxFzYwB7DKd8v+SbyoSoEHUw8O4x7zZCwpVxHQQeDZG2a WISXQ2ypuHNs8FBYouXWkBN0JIesfsYOotF2OT3PNScFIog+EBnpsnSEPp5+Cft4geUE jn9f6oAg0Nv6xAxtyPuFa9FJzlHUmt3a2TM8zANy8tRYzhxXvbFO2NsCnSOA199WYcOK 8PwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=opYVatSslr8WQkpUTuzfg2/jmb+MHi02RVB8L0MaPpw=; b=WfWNUSaxNgo7vffIl+rJRU7Ats78lJK/g+frSvOWYfXTorcLvMlGSw7zWOLBLT0Oi7 bNlksPh+LhCuCZQnbpVWYKVLf3cGcuX9u4WQV/m1tMbkZ/rd0fJvHQ7XRWpTpG+z8mGG iyKny1VvXrmES91oRV1nC8zQ89P27VR5nIxbD+xHq3A/qde6ioNMaN77dqPxbAlbEkk/ lV0nOBcot9HXX9ptqDprzSvypQIJv/dJvhlbGvGJ3UBZSx9qTIKtHiat/DElUzUxeWco iwOxqp4p7mZNwDpc9grZETbvgy16gSc4UMsbkuEOme84yLpVXTSYLTbePJdM5Kf951ty UHaw== X-Gm-Message-State: ALKqPwfA9BNEwaVNUSCQo9uCXl91cUxwZ7y6z0ZUZ/3B3U+cxIAn658s cUS27hwJVKYvnOqxrxXRPE7+1Q== X-Google-Smtp-Source: ADUXVKKUkj0KgbSBVFZng6ayZAAF93gBQ9Fz+dEMz7Z848OLMqqZQnksSCMCnUGB9A2t/TnfRFII9g== X-Received: by 2002:a6b:8f84:: with SMTP id r126-v6mr15754063iod.233.1528153083920; Mon, 04 Jun 2018 15:58:03 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id w8-v6sm5057986iof.84.2018.06.04.15.58.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Jun 2018 15:58:03 -0700 (PDT) In-Reply-To: <1dff07f6-8da4-4e4c-a700-0bc39d6f2aa6@live.com> ("=?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel"'s message of "Mon, 4 Jun 2018 16:06:55 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146976 Archived-At: Cl=C3=A9ment Pit-Claudel writes: > The following works: > (let ((x 1)) (cl-incf x nil)) > > =E2=80=A6 but following raises "setq: Wrong type argument: number-or-mark= er-p, nil": > (let ((x 1) (y nil)) (cl-incf x y)) > > =E2=80=A6 yet the docs say this, which suggests that both should work: > (cl-incf PLACE &optional X) > Increment PLACE by X (1 by default). X is an optional macro parameter, so the "optionalness" applies at compile time. > The issue comes from the expansion of cl-incf: > > (defmacro cl-incf (place &optional x) =E2=80=A6 > (if (symbolp place) > (list 'setq place (if x (list '+ place x) (list '1+ place))) > (list 'cl-callf '+ place (or x 1)))) > > Shouldn't that `if x' check be quoted? Same for the second branch of the= if (shouldn't the `(or x 1)' part be quoted, too?) I think that would approximately double the cost of cl-incf in the simple case. And since you would expect cl-incf to be used in loops a lot, that seems like a bad idea.