From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#31988: scroll-other-window broken on master Date: Sat, 07 Jul 2018 17:14:29 +0300 Message-ID: <874lhb16be.fsf@tcd.ie> References: <87sh57ncom.fsf@tcd.ie> <18f5ace80f052837c724d942d832a146.squirrel@dancol.org> <874lhc9fax.fsf@tcd.ie> <7e1589a2b0bdd4a07d6826b594a96ab5.squirrel@dancol.org> <83pnzzjxl5.fsf@gnu.org> <87a7r317we.fsf@tcd.ie> <83wou7i288.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1530972786 29285 195.159.176.226 (7 Jul 2018 14:13:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 7 Jul 2018 14:13:06 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 31988@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 07 16:13:02 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbnxN-0007SP-BD for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Jul 2018 16:13:01 +0200 Original-Received: from localhost ([::1]:33833 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbnzU-00083w-EG for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Jul 2018 10:15:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbnzO-00083o-6c for bug-gnu-emacs@gnu.org; Sat, 07 Jul 2018 10:15:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbnzL-0002Mv-07 for bug-gnu-emacs@gnu.org; Sat, 07 Jul 2018 10:15:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42335) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fbnzK-0002Md-RI for bug-gnu-emacs@gnu.org; Sat, 07 Jul 2018 10:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fbnzK-0005Dp-DD for bug-gnu-emacs@gnu.org; Sat, 07 Jul 2018 10:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jul 2018 14:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31988 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31988-submit@debbugs.gnu.org id=B31988.153097288520032 (code B ref 31988); Sat, 07 Jul 2018 14:15:02 +0000 Original-Received: (at 31988) by debbugs.gnu.org; 7 Jul 2018 14:14:45 +0000 Original-Received: from localhost ([127.0.0.1]:50232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbnz2-0005D2-OP for submit@debbugs.gnu.org; Sat, 07 Jul 2018 10:14:44 -0400 Original-Received: from mail-wr1-f51.google.com ([209.85.221.51]:34547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbnz0-0005Co-La for 31988@debbugs.gnu.org; Sat, 07 Jul 2018 10:14:43 -0400 Original-Received: by mail-wr1-f51.google.com with SMTP id c13-v6so6633404wrt.1 for <31988@debbugs.gnu.org>; Sat, 07 Jul 2018 07:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=lHncBclgtvutyvqGUpHidI+7RRFsGPJ8tVYxkcQUO+w=; b=dStkC2QKU1ULS0l7/HrBr2DHxftNNpTKAMe8X2D9OEnDcoDcT4YjEwojHGEQVzjDqy xODPCJ1w731KFm8oXgUblrz0mbEii6ybrVxollrxgphY0/XQ/KcYWgCD+uKyomHyD13q Kt0vVckrFJWXfED1vqJByvCcf4KAWjvOCxjO6gIgOQEUVoZ+9O7yrcMLzGwjCpDlFiWn 8nWq5fudbbX2nROIE9YflGLsWGw5xEskuIBpJMKXlaL5Me42UFqWMePj0zHy8hVrvcZj HwBzm5QNherENp4yvgtxfj88vV5NzoLCVspJnqupsZhbD+oqgGWLLOiKOI8mOiVGoLCd K2ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=lHncBclgtvutyvqGUpHidI+7RRFsGPJ8tVYxkcQUO+w=; b=gxo6AEcsUR2r7otsnCRsKto1vFQjAkmyo3bXYB+54Pqwc0wFGvjMsB/llaho4YLdVs /NouRwMpi4DO6uVPWS5AU1PzC1Mu8lJqPNtjgom7kU9mEH9QhhxXC9AciZKN/JpFhYui yrc1a7C8oMtKTH5E4UHvctmirxBjSvMBqt9ZfdYUdSkFDk62i3skip5BB6DZV8hoJHZe A3NzV1pvZJ7EwUSuHHwb7ERyZeXexg0YLvkLOHdjJFjh/hUplCSNiQu4BSks2tOr0y1r /AFmgRxJn1SZxiv4fCrDOME7dYb1cxAdomCB9tw8VRtaH45uuTDY9HK/n0ssNOu5Yriy 8tQg== X-Gm-Message-State: APt69E0P8yjMLxPY623ms3JUi1wlHfhkHHTLOFSTSzkDt8iy1fvdlta9 gwYVnzIw792ZLtR62Ca0gQMb3mLm X-Google-Smtp-Source: AAOMgpddmssSWcXOpcFds48/LMneLZkGZ2DvFLSrKW0Vwa3/yZ9kEGfEHdw5d4DdgarCRB+vicL3qA== X-Received: by 2002:a5d:46c6:: with SMTP id g6-v6mr9513056wrs.76.1530972876974; Sat, 07 Jul 2018 07:14:36 -0700 (PDT) Original-Received: from localhost (adsl-112.91.140.88.tellas.gr. [91.140.88.112]) by smtp.gmail.com with ESMTPSA id p184-v6sm5791556wmp.43.2018.07.07.07.14.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 07 Jul 2018 07:14:36 -0700 (PDT) In-Reply-To: <83wou7i288.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 7 Jul 2018 16:50:47 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148300 Archived-At: Eli Zaretskii writes: >> From: "Basil L. Contovounesios" >> Cc: Daniel Colascione , <31988@debbugs.gnu.org>, >> <31988-done@debbugs.gnu.org> >> Date: Sat, 07 Jul 2018 16:40:17 +0300 >> >> I don't yet feel particularly good at or confident with writing >> changelog entries, let alone Emacs C code, so any guidance is more than >> welcome now and in the future. > > I think you are doing just fine, thank you. There's always some > learning curve, of course. CONTRIBUTE should tell you enough, and you > can study the log messages by veterans to pick up the spirit. > > The "inaccurate" part in my message related not to your wording (which > was fine, AFAICT), but to the fact that the important part of your fix > was to call save-excursion in the described case, not the part that > set the buffer (which was actually a no-op). > >> I'm not sure whether Daniel's addition of the 'close' tag had the >> intended effect > > It should have, but it looks like it didn't for some reason. > >> so I'm taking the liberty of CCing <31988-done@debbugs.gnu.org>; if >> this was the wrong thing to do, please let me know what I should >> have done instead. > > Doing that for a bug that should be closed can never do any harm, even > if it was already closed. (You also don't need to CC both NNN@ and > NNN-done@, as the message gets recorded by the tracker even if you > only use the latter.) Thanks for explaining everything, it all makes sense. -- Basil