* bug#32945: [PATCH] Prefer delete-char
@ 2018-10-05 14:11 Alex Branham
2018-10-12 8:40 ` Eli Zaretskii
2018-10-15 20:07 ` Glenn Morris
0 siblings, 2 replies; 3+ messages in thread
From: Alex Branham @ 2018-10-05 14:11 UTC (permalink / raw)
To: 32945
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
Hi -
This is a trivial change that silences the byte compiler warning in
lisp/eshell/em-rebind.el.
Thanks for all your work on Emacs!
Alex
From 40563de898d99a81d05d3d1585f753e20f815b60 Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham@gmail.com>
Date: Fri, 5 Oct 2018 09:07:13 -0500
Subject: [PATCH] ; lisp/eshell/em-rebind.el (eshell-delete-backward-char):
Prefer delete-char
---
lisp/eshell/em-rebind.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/eshell/em-rebind.el b/lisp/eshell/em-rebind.el
index e6f04b68e0..064dcc762d 100644
--- a/lisp/eshell/em-rebind.el
+++ b/lisp/eshell/em-rebind.el
@@ -223,7 +223,7 @@ lock it at that."
(interactive "P")
(let ((count (prefix-numeric-value n)))
(if (eshell-point-within-input-p (- (point) count))
- (delete-backward-char count n)
+ (delete-char (- count) n)
(beep))))
(defun eshell-delchar-or-maybe-eof (arg)
--
2.19.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#32945: [PATCH] Prefer delete-char
2018-10-05 14:11 bug#32945: [PATCH] Prefer delete-char Alex Branham
@ 2018-10-12 8:40 ` Eli Zaretskii
2018-10-15 20:07 ` Glenn Morris
1 sibling, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2018-10-12 8:40 UTC (permalink / raw)
To: Alex Branham; +Cc: 32945
> From: Alex Branham <alex.branham@gmail.com>
> Date: Fri, 05 Oct 2018 09:11:05 -0500
>
> This is a trivial change that silences the byte compiler warning in
> lisp/eshell/em-rebind.el.
Thanks, pushed to the emacs-26 branch.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#32945: [PATCH] Prefer delete-char
2018-10-05 14:11 bug#32945: [PATCH] Prefer delete-char Alex Branham
2018-10-12 8:40 ` Eli Zaretskii
@ 2018-10-15 20:07 ` Glenn Morris
1 sibling, 0 replies; 3+ messages in thread
From: Glenn Morris @ 2018-10-15 20:07 UTC (permalink / raw)
To: Alex Branham; +Cc: 32945
Alex Branham wrote:
> This is a trivial change that silences the byte compiler warning in
> lisp/eshell/em-rebind.el.
Since eshell-delete-backward-char acts as a replacement for
delete-backward-char in eshell, it's never been obvious to me whether
such a change is the right thing to do.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-15 20:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-05 14:11 bug#32945: [PATCH] Prefer delete-char Alex Branham
2018-10-12 8:40 ` Eli Zaretskii
2018-10-15 20:07 ` Glenn Morris
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.