all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alex Branham <alex.branham@gmail.com>
To: 32945@debbugs.gnu.org
Subject: bug#32945: [PATCH] Prefer delete-char
Date: Fri, 05 Oct 2018 09:11:05 -0500	[thread overview]
Message-ID: <874le0fpqe.fsf@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]

Hi -

This is a trivial change that silences the byte compiler warning in
lisp/eshell/em-rebind.el.

Thanks for all your work on Emacs!
Alex

From 40563de898d99a81d05d3d1585f753e20f815b60 Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham@gmail.com>
Date: Fri, 5 Oct 2018 09:07:13 -0500
Subject: [PATCH] ; lisp/eshell/em-rebind.el (eshell-delete-backward-char):
 Prefer delete-char

---
 lisp/eshell/em-rebind.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/eshell/em-rebind.el b/lisp/eshell/em-rebind.el
index e6f04b68e0..064dcc762d 100644
--- a/lisp/eshell/em-rebind.el
+++ b/lisp/eshell/em-rebind.el
@@ -223,7 +223,7 @@ lock it at that."
   (interactive "P")
   (let ((count (prefix-numeric-value n)))
     (if (eshell-point-within-input-p (- (point) count))
-	(delete-backward-char count n)
+	(delete-char (- count) n)
       (beep))))

 (defun eshell-delchar-or-maybe-eof (arg)
--
2.19.0

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

             reply	other threads:[~2018-10-05 14:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05 14:11 Alex Branham [this message]
2018-10-12  8:40 ` bug#32945: [PATCH] Prefer delete-char Eli Zaretskii
2018-10-15 20:07 ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874le0fpqe.fsf@gmail.com \
    --to=alex.branham@gmail.com \
    --cc=32945@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.