From: Tino Calancha <tino.calancha@gmail.com>
To: "積丹尼 Dan Jacobson" <jidanni@jidanni.org>
Cc: 32969@debbugs.gnu.org
Subject: bug#32969: "Confirm--do you mean to use ‘*’ as a wildcard? (y or n)" stays in minibuffer
Date: Mon, 08 Oct 2018 02:44:12 +0900 [thread overview]
Message-ID: <874ldx649f.fsf@calancha-pc.dy.bbexcite.jp> (raw)
In-Reply-To: <87murquen9.fsf@jidanni.org> ("積丹尼 Dan Jacobson"'s message of "Sun, 07 Oct 2018 20:26:02 +0800")
積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:
> Dired has a message:
> Confirm--do you mean to use ‘*’ as a wildcard? (y or n)
> if one answers "n" the message just stays in the minibuffer.
>
> It should instead say "command aborted", else the user thinks it used
> '*' in its other (text replacement) way. Which it turns out it doesn't.
Thank you for the report!
I agree.
--8<-----------------------------cut here---------------start------------->8---
commit e76bbfa62b7185cd3284d69483704366dc54e7e8
Author: Tino Calancha <tino.calancha@gmail.com>
Date: Mon Oct 8 02:40:30 2018 +0900
dired-do-shell-command: Notify users after abort the command
* lisp/dired-aux.el (dired-do-shell-command): Notify users that
the command have aborted when they answer 'n' to the prompt (Bug#32969).
diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
index 1f13204b7c..a4145eb67a 100644
--- a/lisp/dired-aux.el
+++ b/lisp/dired-aux.el
@@ -763,16 +763,17 @@ dired-do-shell-command
(y-or-n-p (format-message
"Confirm--do you mean to use `?' as a wildcard? ")))
(t))))
- (when ok
- (if on-each
- (dired-bunch-files (- 10000 (length command))
- (lambda (&rest files)
- (dired-run-shell-command
- (dired-shell-stuff-it command files t arg)))
- nil file-list)
- ;; execute the shell command
- (dired-run-shell-command
- (dired-shell-stuff-it command file-list nil arg)))))))
+ (cond ((not ok) (message "OK, canceled"))
+ (t
+ (if on-each
+ (dired-bunch-files (- 10000 (length command))
+ (lambda (&rest files)
+ (dired-run-shell-command
+ (dired-shell-stuff-it command files t arg)))
+ nil file-list)
+ ;; execute the shell command
+ (dired-run-shell-command
+ (dired-shell-stuff-it command file-list nil arg))))))))
;; Might use {,} for bash or csh:
(defvar dired-mark-prefix ""
--8<-----------------------------cut here---------------end--------------->8---
next prev parent reply other threads:[~2018-10-07 17:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-07 12:26 bug#32969: "Confirm--do you mean to use ‘*’ as a wildcard? (y or n)" stays in minibuffer 積丹尼 Dan Jacobson
2018-10-07 17:44 ` Tino Calancha [this message]
2018-10-07 18:23 ` Eli Zaretskii
2018-10-07 19:43 ` Tino Calancha
2018-10-08 2:27 ` Eli Zaretskii
2018-10-08 7:55 ` Tino Calancha
2018-10-11 8:28 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ldx649f.fsf@calancha-pc.dy.bbexcite.jp \
--to=tino.calancha@gmail.com \
--cc=32969@debbugs.gnu.org \
--cc=jidanni@jidanni.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.