all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@gmail.com>
To: Allen Li <darkfeline@felesatra.moe>
Cc: 32849@debbugs.gnu.org
Subject: bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter
Date: Sun, 28 Oct 2018 14:32:49 -0400	[thread overview]
Message-ID: <874ld5kjla.fsf@gmail.com> (raw)
In-Reply-To: <CADbSrJygDU-KUUcD8xRgP9fK_zUs6=iQTpUmtp9QLNZ3CVagHQ@mail.gmail.com> (Allen Li's message of "Wed, 24 Oct 2018 21:30:51 -0600")

Allen Li <darkfeline@felesatra.moe> writes:

> I wrote tests with names function-to-test/case-tested.  I'm not sure
> if this violates style policies for tests.  It seems like existing
> code tests multiple cases in a single test, but I find separate tests
> easier to understand when they regress.  The / makes the test names
> easier to read.
  
> +(ert-deftest ring-test-ring-resize/grow ()

Like Eli mentioned, there is no policy for this, but I'd say the
ring-test- prefix is redundant for test names, ring-resize/grow already
has the prefix ring- to avoid nameclashes with other tests (and test
namespace is separate from function namespace).





      parent reply	other threads:[~2018-10-28 18:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-26 23:14 bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter Allen Li
2018-09-27  8:24 ` Eli Zaretskii
2018-10-25  3:30   ` Allen Li
2018-10-27  9:57     ` Eli Zaretskii
2018-11-09  7:01       ` Allen Li
2018-11-10  9:47         ` Eli Zaretskii
2018-10-28 18:32     ` Noam Postavsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ld5kjla.fsf@gmail.com \
    --to=npostavs@gmail.com \
    --cc=32849@debbugs.gnu.org \
    --cc=darkfeline@felesatra.moe \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.