From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#33567: Syntactic fontification of diff hunks Date: Thu, 27 Dec 2018 00:49:44 +0200 Organization: LINKOV.NET Message-ID: <874lazq5e7.fsf@mail.linkov.net> References: <878t18j4is.fsf@mail.linkov.net> <87k1koygvm.fsf@mail.linkov.net> <83r2ew8mfx.fsf@gnu.org> <87va475y1m.fsf@mail.linkov.net> <87mupafi73.fsf@mail.linkov.net> <834lbgh3n7.fsf@gnu.org> <87h8fduis0.fsf@mail.linkov.net> <83d0q0dtc0.fsf@gnu.org> <877eg7sq8a.fsf@mail.linkov.net> <47546098-59ef-ae43-878a-fd225b60ec99@yandex.ru> <874lba1n0n.fsf@mail.linkov.net> <87d0pyxtnc.fsf@mail.linkov.net> <532bc1dc-1b44-dc3a-23f0-f96e6d586123@yandex.ru> <09b2c002-1519-61dd-6e8b-2e87794077e2@yandex.ru> <87zht1jjdf.fsf@mail.linkov.net> <75267609-e167-c26e-82e8-d6c2609dbf30@yandex.ru> <8736qrkgel.fsf@mail.linkov.net> <87bm59tkuk.fsf@mail.linkov.net> <32b6a823-e855-7a47-86f4-d2d33fdb2c2b@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1545865545 25692 195.159.176.226 (26 Dec 2018 23:05:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 26 Dec 2018 23:05:45 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 33567@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 27 00:05:41 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gcIFA-0006ZU-KI for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Dec 2018 00:05:41 +0100 Original-Received: from localhost ([127.0.0.1]:48643 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcIHH-0001ko-6K for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Dec 2018 18:07:51 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:54175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcIGm-0001UW-0X for bug-gnu-emacs@gnu.org; Wed, 26 Dec 2018 18:07:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gcIGZ-0005sQ-Mj for bug-gnu-emacs@gnu.org; Wed, 26 Dec 2018 18:07:16 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47596) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gcIGU-0005YC-CP for bug-gnu-emacs@gnu.org; Wed, 26 Dec 2018 18:07:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gcIGT-0005Wf-TJ for bug-gnu-emacs@gnu.org; Wed, 26 Dec 2018 18:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Dec 2018 23:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33567-submit@debbugs.gnu.org id=B33567.154586560721205 (code B ref 33567); Wed, 26 Dec 2018 23:07:01 +0000 Original-Received: (at 33567) by debbugs.gnu.org; 26 Dec 2018 23:06:47 +0000 Original-Received: from localhost ([127.0.0.1]:38026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gcIGE-0005Vx-OY for submit@debbugs.gnu.org; Wed, 26 Dec 2018 18:06:46 -0500 Original-Received: from firebrick.maple.relay.mailchannels.net ([23.83.214.59]:36715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gcIGB-0005Vk-Nm for 33567@debbugs.gnu.org; Wed, 26 Dec 2018 18:06:44 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 104693E2FB9; Wed, 26 Dec 2018 23:06:42 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a49.g.dreamhost.com (unknown [100.96.19.74]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id A2F763E3C12; Wed, 26 Dec 2018 23:06:41 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a49.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Wed, 26 Dec 2018 23:06:42 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Troubled-Unite: 1903d32a1e91d9ab_1545865601841_3827028765 X-MC-Loop-Signature: 1545865601841:3210367107 X-MC-Ingress-Time: 1545865601840 Original-Received: from pdx1-sub0-mail-a49.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a49.g.dreamhost.com (Postfix) with ESMTP id 48BE67FC5E; Wed, 26 Dec 2018 15:06:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=7NHH/dkhegGhAA0d45o/dB1yjuc=; b= btNyhCm2gNdB31yPFtdzEupjiiGjQRQyvR5N3rlblmas+A97CkBlcUjwa9u3t2G2 qjmkMY5H9haHGmuLOopOxuf8hxnSELdyMkOFEqfOP39u/noWPuJF6KwbH/4AXTl8 E/U+5ezxTWUVEalAIRSU5C4wEKA9BeuFh8i9oGdoO84= Original-Received: from mail.jurta.org (m91-129-108-193.cust.tele2.ee [91.129.108.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a49.g.dreamhost.com (Postfix) with ESMTPSA id 168407FC59; Wed, 26 Dec 2018 15:06:38 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a49 In-Reply-To: <32b6a823-e855-7a47-86f4-d2d33fdb2c2b@yandex.ru> (Dmitry Gutov's message of "Tue, 25 Dec 2018 23:15:19 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtledrtddugddtiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepledurdduvdelrddutdekrdduleefnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtkedrudelfedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegughhuthhovheshigrnhguvgigrdhruhenucevlhhushhtvghrufhiiigvpedt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153875 Archived-At: >> What do you think about this solution that combines both >> green/red foreground colors with syntax colors: >> >> https://gist.github.com/skanev/0eeb943e3111a1df55fd > > This is almost the look I complained about previously, but if the green and > red are not as sharp, I suppose it's not too terrible. At least the lighter > red doesn't scream "errors" to me. > > But note that this example does not show any "refined" functionality. There are some underlines on this screenshot, maybe use underlines for refined diffs on tty?