From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: making xref.el a core ELPA package Date: Thu, 27 Dec 2018 21:41:12 +0000 Message-ID: <874layhclj.fsf@gmail.com> References: <87a7ktqqx7.fsf@mail.linkov.net> <9215183d-0a44-88b5-5b3c-d0da31f749ad@yandex.ru> <65bd653b-bc09-035b-5f5e-4b7b32fe9c0e@yandex.ru> <87efa2hmv4.fsf@gmail.com> <87r2e294zc.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1545946799 3754 195.159.176.226 (27 Dec 2018 21:39:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 27 Dec 2018 21:39:59 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel , Dmitry Gutov To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 27 22:39:55 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gcdNi-0000rh-Hr for ged-emacs-devel@m.gmane.org; Thu, 27 Dec 2018 22:39:54 +0100 Original-Received: from localhost ([127.0.0.1]:55374 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcdPo-0005eN-UD for ged-emacs-devel@m.gmane.org; Thu, 27 Dec 2018 16:42:04 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:51926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcdPB-0005eE-S2 for emacs-devel@gnu.org; Thu, 27 Dec 2018 16:41:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gcdP5-00069w-QF for emacs-devel@gnu.org; Thu, 27 Dec 2018 16:41:25 -0500 Original-Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:39174) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gcdP3-00063a-Ol for emacs-devel@gnu.org; Thu, 27 Dec 2018 16:41:19 -0500 Original-Received: by mail-wr1-x433.google.com with SMTP id t27so19425120wra.6 for ; Thu, 27 Dec 2018 13:41:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=hn1EH5Q7fnWk3UJUUZ6HEkDDSkmDHkGnDOweQUJF0v0=; b=hzEvOYdqIKQpfySXGfjrrgnJ6yFzShm3Bh0emwx/hunk3i22tgOF0SMWfIauMfbL9Z hUry9ZvpgXlB8vIE/4JIH+85OsGwUDPY6kjq2yYKiQkjz7D0GnPw2n6gOzCqIruOO4hS 6YOCeASE5vMk4CKuTeX+rNQs0D4vd9Z+PrKsr/iE9PeQAZQ77hpGMDR0QLYvKcUdUftp SzIAD+yHDX01nBgWMme5gR+T6BFmLjg4thUqXCMrImNoFbcKUblCuBf2ps7S0o2z/O7m PcvHkcgzQnfV/EsAR8OXStUQmM8GL0ugEjPA1esGwBlKoucjuAc3HZL1WrMoV0RNj/HE 1Ipw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=hn1EH5Q7fnWk3UJUUZ6HEkDDSkmDHkGnDOweQUJF0v0=; b=tg8rENm2Aq4Vcu47+hanlLY4U4IDCrwy4WZuUlwFJG2cMKNhvn6wg9ZimydWS1evjf KjakB/tGkEyVRj5VIpQd2LnVQkzGIazisC2LX6sVCNhS0EhjDudt7Asu1F7zRzOCeTM+ NQ9dmCCdDoC/NjSYpBmcqB08Djv2qkoRVbsbwmVwV8EOPbY0BMgNAXYctl5C7tN8+GNH P6lTOyGNI2Hppl0Q7dyeQzNav+KcG03RcgDABeEjLK1DAxc4GSQd8vMq89scSDXrfcyq gNB3oecg5Kooni/HSpje/3ZUVINBVEv3rwAq7CkuQIFJ8eaZo2lBtaJOhpQSomdzu9ZH bAqQ== X-Gm-Message-State: AJcUukdzR38us6J/WAESp3ShAZEgPH75aiclMZSrp00I0yt2oqmYqu9i j0aZmjyU89ONP0m1hXSsn2cTHjbX X-Google-Smtp-Source: ALg8bN51wxR/mEgMX++fNwDy6a8/8vIDC43/9UzNpLCi3ej/+Njxx0R1H+HvlZ5AhI43XmpwvR/Tvg== X-Received: by 2002:adf:ffca:: with SMTP id x10mr24559246wrs.289.1545946875780; Thu, 27 Dec 2018 13:41:15 -0800 (PST) Original-Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id l14sm76910343wrp.55.2018.12.27.13.41.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Dec 2018 13:41:15 -0800 (PST) In-Reply-To: <87r2e294zc.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 27 Dec 2018 22:12:55 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::433 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232010 Archived-At: Juri Linkov writes: >> Unfortunately, I just tested with 26.1 and no go. It doesn't have >> next-error-found :-( This is the commit: >> >> commit 0c9e3df3c2088b61feb4b4e00d24419459962273 >> Author: Juri Linkov >> Date: Tue Apr 17 22:27:48 2018 +0300 >> >> Use next-error-found to set next-error-last-buffer. > > It's a big surprise to me that xref is a standalone package. There is a misunderstanding here. It's not, but I am proposing that it become a semi-standlone pacakge. > I thought it's simply a better replacement of the old find-tag. It is. >> Either: >> >> * we revert this (I believe we shouldn't) >> * we use some indirection that is a no-op in 26.1 > > Sure, you could add some conditionals to support older versions. It's kinda lame to do this in a file that is in Emacs core, but if the others accept and it's a one-time well-documented thing, fine by be. A proper indirection (hook/function variable) would be better, but not really justified by this one use case. Jo=C3=A3o