all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#33830: 27.0.50; help-xref-stack contains bad entries
@ 2018-12-21 16:55 Alex Branham
  2018-12-27 22:38 ` Federico Tedin
  2021-06-23 13:58 ` Lars Ingebrigtsen
  0 siblings, 2 replies; 4+ messages in thread
From: Alex Branham @ 2018-12-21 16:55 UTC (permalink / raw)
  To: 33830

Sometimes `help-xref-stack' contains "bad" entries, which makes
help-go-forward and help-go-back error in a strange way. To see what I
mean:

emacs -q

C-h f car RET
C-h k C-x t
C-h f cdr RET

Now that the *Help* buffer is displaying `cdr', if you try to go back
(with "l" or clicking the back button), you get "user-error C-x t is
undefined".

Alex





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#33830: 27.0.50; help-xref-stack contains bad entries
  2018-12-21 16:55 bug#33830: 27.0.50; help-xref-stack contains bad entries Alex Branham
@ 2018-12-27 22:38 ` Federico Tedin
  2021-06-23 13:58 ` Lars Ingebrigtsen
  1 sibling, 0 replies; 4+ messages in thread
From: Federico Tedin @ 2018-12-27 22:38 UTC (permalink / raw)
  To: Alex Branham; +Cc: 33830

Alex Branham <alex.branham@gmail.com> writes:

> Sometimes `help-xref-stack' contains "bad" entries, which makes
> help-go-forward and help-go-back error in a strange way. To see what I
> mean:
>
> emacs -q
>
> C-h f car RET
> C-h k C-x t
> C-h f cdr RET
>
> Now that the *Help* buffer is displaying `cdr', if you try to go back
> (with "l" or clicking the back button), you get "user-error C-x t is
> undefined".
>
> Alex

I've noticed that the `describe-key' and `describe-function' functions both
call `help-setup-xref' with key sequences and functions respectively,
even if said key sequences or functions are not valid (i.e. when the key
sequence isn't bound to anything and the function does not exist).

An example of this:

1) M-:: (describe-function 'hello) RET
2) C-h f car RET
3) On the *Help* buffer, press 'l'

The message 'Symbol’s function definition is void: hello' will be
displayed, and the *Help* buffer will contain "hello is ". Also, for
some reason, after pressing 'r', two [back] buttons will be shown.

Maybe `help-setup-xref' should only be called when it is certain that
the key sequence/function/etc. exists?

(tested on master branch)





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#33830: 27.0.50; help-xref-stack contains bad entries
  2018-12-21 16:55 bug#33830: 27.0.50; help-xref-stack contains bad entries Alex Branham
  2018-12-27 22:38 ` Federico Tedin
@ 2021-06-23 13:58 ` Lars Ingebrigtsen
  2021-07-22 14:20   ` Lars Ingebrigtsen
  1 sibling, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-06-23 13:58 UTC (permalink / raw)
  To: Alex Branham; +Cc: 33830

Alex Branham <alex.branham@gmail.com> writes:

> Sometimes `help-xref-stack' contains "bad" entries, which makes
> help-go-forward and help-go-back error in a strange way. To see what I
> mean:
>
> emacs -q
>
> C-h f car RET
> C-h k C-x t
> C-h f cdr RET
>
> Now that the *Help* buffer is displaying `cdr', if you try to go back
> (with "l" or clicking the back button), you get "user-error C-x t is
> undefined".

This doesn't exactly reproduce for me in Emacs 27.1, because `C-x t' is
bound there.  But this works:

C-h f car RET
C-h k C-x t t
C-h f cdr RET
C-x o
l

I do get the "is undefined" message, but then hitting `l' again takes me
back to `car'.

I guess it could make sense for `l'/`r' to skip these "invalid" entries,
but on the other hand, I can see how they'd be vaguely useful.

Does anybody have any opinions here?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#33830: 27.0.50; help-xref-stack contains bad entries
  2021-06-23 13:58 ` Lars Ingebrigtsen
@ 2021-07-22 14:20   ` Lars Ingebrigtsen
  0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-07-22 14:20 UTC (permalink / raw)
  To: Alex Branham; +Cc: 33830

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I guess it could make sense for `l'/`r' to skip these "invalid" entries,
> but on the other hand, I can see how they'd be vaguely useful.
>
> Does anybody have any opinions here?

Nobody had, so I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-22 14:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-21 16:55 bug#33830: 27.0.50; help-xref-stack contains bad entries Alex Branham
2018-12-27 22:38 ` Federico Tedin
2021-06-23 13:58 ` Lars Ingebrigtsen
2021-07-22 14:20   ` Lars Ingebrigtsen

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.