From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#33870: 27.0.50; xref-goto-xref not configurable Date: Tue, 08 Jan 2019 00:16:19 +0200 Organization: LINKOV.NET Message-ID: <874lak9kr0.fsf@mail.linkov.net> References: <87a7ktqqx7.fsf@mail.linkov.net> <9215183d-0a44-88b5-5b3c-d0da31f749ad@yandex.ru> <878t02egph.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1546899856 16419 195.159.176.226 (7 Jan 2019 22:24:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 7 Jan 2019 22:24:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 33870@debbugs.gnu.org, Dmitry Gutov To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 07 23:24:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggdJb-0004Am-BD for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Jan 2019 23:24:11 +0100 Original-Received: from localhost ([127.0.0.1]:49528 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggdLi-0002x6-BO for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Jan 2019 17:26:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggdKS-0001vT-3s for bug-gnu-emacs@gnu.org; Mon, 07 Jan 2019 17:25:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggdKR-0005C7-CN for bug-gnu-emacs@gnu.org; Mon, 07 Jan 2019 17:25:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49769) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggdKR-0005Bz-8v for bug-gnu-emacs@gnu.org; Mon, 07 Jan 2019 17:25:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ggdKR-0000kr-3y for bug-gnu-emacs@gnu.org; Mon, 07 Jan 2019 17:25:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Jan 2019 22:25:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33870 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33870-submit@debbugs.gnu.org id=B33870.15468998732845 (code B ref 33870); Mon, 07 Jan 2019 22:25:03 +0000 Original-Received: (at 33870) by debbugs.gnu.org; 7 Jan 2019 22:24:33 +0000 Original-Received: from localhost ([127.0.0.1]:49049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggdJw-0000jo-JO for submit@debbugs.gnu.org; Mon, 07 Jan 2019 17:24:32 -0500 Original-Received: from palegreen.birch.relay.mailchannels.net ([23.83.209.140]:2888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggdJu-0000jg-UQ for 33870@debbugs.gnu.org; Mon, 07 Jan 2019 17:24:31 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id EE5B412440A; Mon, 7 Jan 2019 22:24:29 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a35.g.dreamhost.com (unknown [100.96.35.77]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 85304124AA2; Mon, 7 Jan 2019 22:24:29 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a35.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Mon, 07 Jan 2019 22:24:29 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Plucky-Absorbed: 4f74493b7a599ced_1546899869774_2220148134 X-MC-Loop-Signature: 1546899869774:3588575477 X-MC-Ingress-Time: 1546899869773 Original-Received: from pdx1-sub0-mail-a35.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a35.g.dreamhost.com (Postfix) with ESMTP id 349F17F5B8; Mon, 7 Jan 2019 14:24:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=sjAgyp4PmdEuRfvi4LlMgANiut0=; b= fjDgMnC3c8kF32cXbs6B045t1YEYoRA582UxRJyZ42BAvFLVyWVOBGvlWwd0hTCT zvPwI65zXdoXaQAp51VFyWqz5Rz7cp4tOnsyADPsN+K5GpOqWkiuZzVlYwFnu28B NO7OKLQgs4YKb6XXuUn3zhM/+XUBeSj7aP2mg1Tb6FY= Original-Received: from mail.jurta.org (m91-129-109-141.cust.tele2.ee [91.129.109.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a35.g.dreamhost.com (Postfix) with ESMTPSA id E63687F4DE; Mon, 7 Jan 2019 14:24:25 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a35 In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Mon, 07 Jan 2019 14:21:55 +0000") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtledrvdejgdduheekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdelrddugedunecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtledrudeguddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehjohgrohhtrghvohhrrgesghhmrghilhdrtghomhenucevlhhushhtvghrufhiiigvpedu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154237 Archived-At: > After re-reading your patch more closely and giving it some more > testing, I've discovered it breaks an existing use case: > > Emacs -Q > C-x 2 ;; split-window-horizontally > C-x 4 . ;; xref-find-definitions-other-window > xref-backend-definitions RET > C-n RET ;; in the resulting *xref* buffer Of course, it doesn't work if you tried it only with part of my changes. When I submitted my initial patch, I tested it in all your test cases, including the above test case that was not broken with my patch. But you asked to break my patch to several pieces and submit them separately to different bug reports. No wonder that each of them doesn't do what the whole patch did. > Expected xref.el to appear in the bottom window which was my original > intent when I said "other window". Then the xref buffer is obscured by another buffer visited in the same window, and if the user wants to visit more hits from the xref buffer, this is not easy to do. > In the current master this works OK, in your patch it doesn't. My initial patch solved this problem gracefully by creating a new window for the xref buffer. > I've also renamed window.el's window--display-buffer to > window-display-buffer throughout Emacs (i.e. made it public). You can't rename old functions lightly. This will break the existing code. This needs many years of deprecation process: in one release declare the function as obsolete, and in another release delete old aliases, because there are external packages that rely on this function name like the `other-frame-window' package from ELPA, etc. > After we merge this, we can continue the discussion about the changing > the xref UI in the other bug you opened, bug#33992 Better start with bug#33992 because it supports the above test case, then we could finish this bug#33870.