From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pierre Neidhardt Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: disk-usage Date: Tue, 19 Feb 2019 21:26:27 +0100 Message-ID: <874l8zr0cs.fsf@ambrevar.xyz> References: <87imxgmacr.fsf@ambrevar.xyz> <874l8z7cmi.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="263683"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.0; emacs 26.1 Cc: Emacs developers To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 19 21:27:33 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gwBzH-0016MD-6v for ged-emacs-devel@m.gmane.org; Tue, 19 Feb 2019 21:27:31 +0100 Original-Received: from localhost ([127.0.0.1]:54632 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwBzG-0007x9-1h for ged-emacs-devel@m.gmane.org; Tue, 19 Feb 2019 15:27:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwByR-0007vn-3C for emacs-devel@gnu.org; Tue, 19 Feb 2019 15:26:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwByP-0004my-OT for emacs-devel@gnu.org; Tue, 19 Feb 2019 15:26:38 -0500 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:45011) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gwByP-0004fv-7U for emacs-devel@gnu.org; Tue, 19 Feb 2019 15:26:37 -0500 X-Originating-IP: 90.92.41.33 Original-Received: from bababa (lfbn-1-12225-33.w90-92.abo.wanadoo.fr [90.92.41.33]) (Authenticated sender: mail@ambrevar.xyz) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 53C651C0005; Tue, 19 Feb 2019 20:26:28 +0000 (UTC) In-reply-to: <874l8z7cmi.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.70.183.197 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233469 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > Thanks! Thanks for the feedback! > Is there a reason you apply `call-process' instead of `process-file'? > With the latter, you could scan also directories on remote machines. Nope, will do, just forgot about it (bad habit). > One suggestion: you know for sure key bindings. Other people won't. > Maybe you could add a menue for your *disk-usage<...>* buffers? Isn't `describe-mode' enough? > Furthermore, could you pls adapt Emacs coding rules? Respecting 80 > columns per line max, providing a docstring for all functions comes to > mind. This would help to read your code. Will do. Cheers! =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlxsZnMACgkQm9z0l6S7 zH8v0Af/R5EtN+qTUislec27+3BAujbZVWsWO9ej7AsleT8AMJqqv/Az4uP6v6Si ectCDwEg94RjP9xAGC/nP672i3IM10C4AYKWrUpS5sN1iiuzHZ8znt69bElTwmui QJsgJhnA9oQjVVJ6BqpTDqVnRLuCQW5QdbHK32aAWmJKSDacWlWnaxONutquYsL0 KneITiulMjAjk2Pr9eHAMTR4mLBELSE4D5rpy7HF/IYWdH8tKN2+SR7fbPmVN4EU w/d9kPd54t2CPSv3lVhUzRJVrd9f6ZgohiB+IgRUMbijn8XO8NjEt4M8fA/+YBtB /WLnjCmMRN+TdtNcHWFkCXguXWT1ww== =2Age -----END PGP SIGNATURE----- --=-=-=--