From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Gramiak Newsgroups: gmane.emacs.devel Subject: Re: Renaming non-X x_* procedures in xdisp.c (and elsewhere) Date: Sat, 13 Apr 2019 10:26:16 -0600 Message-ID: <874l71vplj.fsf@gmail.com> References: <87wokp4okn.fsf@gmail.com> <0f4be9a6-6e09-f55d-9f58-2a15aef264cd@cs.ucla.edu> <837ecpplw8.fsf@gnu.org> <871s2w510a.fsf@gmail.com> <922F9B91-2E9E-45F6-BB96-66CAE5E9FB81@gnu.org> <87k1goqpnn.fsf@gmail.com> <83imw8nspc.fsf@gnu.org> <87ftrcqg5j.fsf@gmail.com> <83bm20nm62.fsf@gnu.org> <87d0men4jx.fsf@gmail.com> <83o95sisk7.fsf@gnu.org> <87mulcnui4.fsf@gmail.com> <83bm1si7lf.fsf@gnu.org> <87ef6ont03.fsf@gmail.com> <83a7hci44l.fsf@gnu.org> <87a7hcndtc.fsf@gmail.com> <831s2nhza8.fsf@gnu.org> <87h8b4tl6n.fsf@gmail.com> <83pnprkpw5.fsf@gnu.org> <87tvf3uhp2.fsf@gmail.com> <83imvjkmrf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="21496"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 13 18:26:33 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hFLU9-0005UG-El for ged-emacs-devel@m.gmane.org; Sat, 13 Apr 2019 18:26:33 +0200 Original-Received: from localhost ([127.0.0.1]:53554 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFLU8-0007DB-CM for ged-emacs-devel@m.gmane.org; Sat, 13 Apr 2019 12:26:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFLU3-0007D3-3F for emacs-devel@gnu.org; Sat, 13 Apr 2019 12:26:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hFLU1-0004hs-KR for emacs-devel@gnu.org; Sat, 13 Apr 2019 12:26:27 -0400 Original-Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:44049) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hFLTv-0004Xc-Sc; Sat, 13 Apr 2019 12:26:21 -0400 Original-Received: by mail-pl1-x62f.google.com with SMTP id g12so6537451pll.11; Sat, 13 Apr 2019 09:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=qzZr1o9C9jBG7JYvAtEpIEFlWb7JjoISGlTLEXV0zxU=; b=iFyztlq+EhSMgCUP9mRimVXAf/4LWzIxLegOoKl4f1KYUYpdEGzM8O/pIz/fG4UyAD YXYsgbgCYyfIGhgCWDKwVZ9xP16U8CHjTLHQvwpiOJnj01reMSPuq4YzDQbEQPpGVPFt qs/PMTu7opdQCs9C85w6h0CrfmicRpL+SCknBckpD4hpAf8jBKzaZgeMyq+5mmKGWqFj S7DKdzOjFv5eW7NdoPsW33tO+/QQ4oKrtc0cgOB/LQsqVMxTohXBUEf028YURqjWaIBw keXBzE+SW0iftPf6mQsrkg/XEgw6vpIrmvC+H0eaZ7eOYHeIhQc6vbOKpq0AKd93enQ6 dacw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qzZr1o9C9jBG7JYvAtEpIEFlWb7JjoISGlTLEXV0zxU=; b=r+NIRzmFUPJT7X8DDWHQrmdVubhU1mj80Yj3MXk8XIfcQMBto+tKcqJDboYmFn/6tv vFbc9M054REl3fv7jGEnWGxY7Bln+p6mIa/YjnT+07Xcn7fxLTc4bw0h6Fb1XRAj75xc 89ajUVSRO7KQNZhRg9IKPAaZX/Gi0C9rZZgUkNMn5nbh2PigBv7osxWbS13n/HPvVi5y BNccELftS3YYIFjowIlPmbaLUFWywC2he32cGUNcykLpYGcvSFCOCrTROMHGkVhWcnye 1/Njpq6eWnnSYBgSVZT9RqW7IS0vqKtTShTH1UGb+jVEbslQlEdAgEsY50vcXKwEWtIK ppoQ== X-Gm-Message-State: APjAAAWPCCoLaOGHodPVR9+rN2OM5M7NZGKE7yc0WJVYbvuMKUR2EGS3 T5OXAh9/lDvkTuNx9JqKJc+9TYKm X-Google-Smtp-Source: APXvYqxMIZYS4HLU0zM2cQhLMXpQUk78Hn3Ux5bXDa6twGAVcPOhrF7GF/7q4Nnafws5nI2bcP7JBg== X-Received: by 2002:a17:902:20c9:: with SMTP id v9mr44596393plg.239.1555172777074; Sat, 13 Apr 2019 09:26:17 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id z14sm67670597pfn.161.2019.04.13.09.26.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 13 Apr 2019 09:26:16 -0700 (PDT) In-Reply-To: <83imvjkmrf.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 Apr 2019 23:10:44 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::62f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235400 Archived-At: >> Equivalently it would check for FRAME_{X,NS,W32}_P. > > Not sure what that means, please elaborate. I just meant implementing FRAME_WINDOW_P using the graphical window system predicates instead of the terminal predicates; the same principle you mentioned in the display-graphic-p thread. >> I believe there should be a comment by the definition of FRAME_WINDOW_P >> that states not to use the return value as a non-boolean. > > It's okay to add such a comment, although the _P part of the name, > which stands for "Predicate", is supposed to say that already. Right, I was just mildly concerned since the comment by it mentions that "it's defined to be the predicate for the window system being used", which might not be good for code to rely on in the very long-term. I removed that part of the comment in the patch series I just posted, is that an acceptable change?