From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#35383: 27.0.50; Complete process of decoding Gnus group names Date: Sat, 18 May 2019 16:23:39 -0700 Message-ID: <874l5r4a9w.fsf@ericabrahamsen.net> References: <878sw1995f.fsf@ericabrahamsen.net> <87sgu87ayo.fsf@ericabrahamsen.net> <87woiuf6ya.fsf@ericabrahamsen.net> <87ef4v4iii.fsf@ericabrahamsen.net> <87r28v76pd.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="258524"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Katsumi Yamaoka , 35383@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 19 01:25:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hS8hZ-00157c-1y for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 May 2019 01:25:17 +0200 Original-Received: from localhost ([127.0.0.1]:39782 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hS8hX-0007H7-Vk for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 May 2019 19:25:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hS8hL-0007F0-NF for bug-gnu-emacs@gnu.org; Sat, 18 May 2019 19:25:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hS8hK-0003mT-PG for bug-gnu-emacs@gnu.org; Sat, 18 May 2019 19:25:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47925) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hS8hK-0003mK-Ln for bug-gnu-emacs@gnu.org; Sat, 18 May 2019 19:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hS8hK-0004ES-G7 for bug-gnu-emacs@gnu.org; Sat, 18 May 2019 19:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 May 2019 23:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35383 X-GNU-PR-Package: emacs Original-Received: via spool by 35383-submit@debbugs.gnu.org id=B35383.155822189216249 (code B ref 35383); Sat, 18 May 2019 23:25:02 +0000 Original-Received: (at 35383) by debbugs.gnu.org; 18 May 2019 23:24:52 +0000 Original-Received: from localhost ([127.0.0.1]:33236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hS8h9-0004E0-V0 for submit@debbugs.gnu.org; Sat, 18 May 2019 19:24:52 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:59536 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hS8h7-0004Dn-Iu for 35383@debbugs.gnu.org; Sat, 18 May 2019 19:24:50 -0400 Original-Received: from localhost (97-113-41-227.tukw.qwest.net [97.113.41.227]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id ABB6EFAF0B; Sat, 18 May 2019 23:24:29 +0000 (UTC) In-Reply-To: <87r28v76pd.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sat, 18 May 2019 23:12:30 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159517 Archived-At: "Basil L. Contovounesios" writes: > Eric Abrahamsen writes: > >> The attached patch should go into master, and then master merged into >> scratch/gnus-decoded. > > [...] > >> diff --git a/lisp/gnus/gnus-start.el b/lisp/gnus/gnus-start.el >> index 2f8a260bf1..16d167613e 100644 >> --- a/lisp/gnus/gnus-start.el >> +++ b/lisp/gnus/gnus-start.el >> @@ -583,11 +583,11 @@ gnus-subscribe-randomly >> >> (defun gnus-subscribe-alphabetically (newgroup) >> "Subscribe new NEWGROUP and insert it in alphabetical order." >> - (let ((groups (cdr gnus-newsrc-alist)) >> + (let ((groups (cdr gnus-group-list)) >> before) >> (while (and (not before) groups) >> - (if (string< newgroup (caar groups)) >> - (setq before (caar groups)) >> + (if (string< newgroup (car groups)) >> + (setq before (car groups)) >> (setq groups (cdr groups)))) >> (gnus-subscribe-newsgroup newgroup before))) > > I noticed gnus-start.el (already) uses seq.el functions without first > loading the library, so how about the following minor addendum? It does require gnus.el, though, which requires seq, so I figured that was good enough -- no compiler warnings, anyway. > (defun gnus-subscribe-alphabetically (newgroup) > "Subscribe new NEWGROUP and insert it in alphabetical order." > - (let ((groups (cdr gnus-group-list)) > - before) > - (while (and (not before) groups) > - (if (string< newgroup (car groups)) > - (setq before (car groups)) > - (setq groups (cdr groups)))) > + (let ((before (seq-find (lambda (group) > + (string< newgroup group)) > + (cdr gnus-group-list)))) > (gnus-subscribe-newsgroup newgroup before))) Looks fine to me! I'll just add this to the patch? Thanks, Eric