From: Noam Postavsky <npostavs@gmail.com>
To: Daniel Ralston <wubbulous@gmail.com>
Cc: 12857@debbugs.gnu.org, deniz@dogan.se
Subject: bug#12857: Re: rcirc.el: make default PART and QUIT reasons customizable
Date: Sat, 01 Jun 2019 20:11:52 -0400 [thread overview]
Message-ID: <874l586e2f.fsf@gmail.com> (raw)
In-Reply-To: <CADWcrk5ESKCjzS_rUv=1fKFYGm_kaE8JPKuoaQ6wFGHcX5dz0A@mail.gmail.com> (Daniel Ralston's message of "Thu, 13 Dec 2012 07:05:08 -0800")
tags 12857 fixed
close 12857 27.1
quit
Daniel Ralston <wubbulous@gmail.com> writes:
> That's a much cleaner way of doing it. I hadn't really looked into
> composite types before, so thanks for the suggestion!
>> This is a good patch! In my opinion it would be nicer if we use a
>> composite customization type for rcirc-default-part-reason and
>> rcirc-default-quit-reason, letting the user choose between the default
>> (rcirc-id-string) and a custom message.
I removed the part that puts the default into the customization type,
since the customization machinery already handles default values just
fine. Pushed to master, with followup NEWS entry.
aa9d57eed1 2019-06-01T20:01:43-04:00 "; Add NEWS entry for previous change"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=aa9d57eed17ee6a8006c9cdd4f8636100482cd71
d3f14ffae4 2019-06-01T20:01:43-04:00 "Make rcirc PART and QUIT reasons customizable (Bug#12857)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d3f14ffae4078688a57acdff30fdd91747386f17
prev parent reply other threads:[~2019-06-02 0:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-10 21:43 bug#12857: rcirc.el: make default PART and QUIT reasons customizable Daniel Ralston
2012-11-23 17:25 ` Deniz Dogan
[not found] ` <50BE7E86.9020601@dogan.se>
2012-12-13 15:05 ` bug#12857: " Daniel Ralston
2016-02-24 6:02 ` Lars Ingebrigtsen
2019-06-02 0:11 ` Noam Postavsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874l586e2f.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=12857@debbugs.gnu.org \
--cc=deniz@dogan.se \
--cc=wubbulous@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.