all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: pierre.techoueyres@free.fr (Pierre Téchoueyres)
To: Eli Zaretskii <eliz@gnu.org>
Cc: Paul Eggert <eggert@Penguin.CS.UCLA.EDU>, emacs-devel@gnu.org
Subject: Re: Add support for base64url variant
Date: Tue, 11 Jun 2019 20:36:52 +0200	[thread overview]
Message-ID: <874l4wt1dn.fsf@killashandra.ballybran.fr> (raw)
In-Reply-To: <834l50pk1p.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 08 Jun 2019 11:18:10 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: pierre.techoueyres@free.fr (Pierre Téchoueyres)
>> Cc: emacs-devel@gnu.org
>> Date: Mon, 27 May 2019 22:30:14 +0200
>> 
>> You'll find two patches attached.
>
> Thanks, I liked the second one better, so I pushed it.

Thank you.  Honestly I didn't expect it was accepted without further
modifications.

>
> Please note that the doc strings and the manual text included a few
> typos, and also used the passive tense too much.  See the follow-up
> changes I pushed after your changeset.  In the future, I suggest to
> use the Emacs spell-checking capabilities to spell-check the text in
> the manual and also the comments/strings in the C/Lisp sources.

This was the part I was the less confident (and for good reasons).
Thanks again to have (completely) rewritten it.  I'll try to be
more rigorous in the future with the doc, NEWS, etc..

I'll also thanks Paul Eggert for his optimizations of the new functions
in commit 5abaea334cf4c0e004fca2b8b272e091eb5b5444.

Pierre.

P.S.
Would it be any interest if I try to add others bases encoding as
defined in RFC 4648 ?  I think, first, to BASE32 and maybe on BASE16
later.



  reply	other threads:[~2019-06-11 18:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 22:32 Add support for base64url variant Pierre Téchoueyres
2019-05-22  7:43 ` Eli Zaretskii
2019-05-22  9:25   ` Pierre Téchoueyres
2019-05-22  9:50     ` Eli Zaretskii
2019-05-23 17:51       ` Pierre Téchoueyres
2019-05-23 18:45         ` Noam Postavsky
2019-05-23 19:32           ` Pierre Téchoueyres
2019-05-23 18:58         ` Eli Zaretskii
2019-05-23 18:50 ` Eli Zaretskii
2019-05-23 19:37   ` Pierre Téchoueyres
2019-05-23 19:51     ` Eli Zaretskii
2019-05-27 20:30       ` Pierre Téchoueyres
2019-06-07 21:04         ` Pierre Téchoueyres
2019-06-08  5:52           ` Eli Zaretskii
2019-06-08  8:18         ` Eli Zaretskii
2019-06-11 18:36           ` Pierre Téchoueyres [this message]
2019-06-11 18:42             ` Eli Zaretskii
2019-06-11 18:47               ` Achim Gratz
2019-06-11 20:14                 ` Richard Copley
2019-06-12 15:34                   ` Eli Zaretskii
2019-06-12  6:50                 ` Stefan Monnier
2019-06-12 19:24                   ` Achim Gratz
2019-06-12 21:50                     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874l4wt1dn.fsf@killashandra.ballybran.fr \
    --to=pierre.techoueyres@free.fr \
    --cc=eggert@Penguin.CS.UCLA.EDU \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.