From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#14769: [PATCH] optimize `concat's literals Date: Sat, 22 Jun 2019 18:17:25 -0400 Message-ID: <874l4huux6.fsf@gmail.com> References: <6BF130E1-F25B-4E1B-B55D-224F0CCEC133@acm.org> <87r27qwdrv.fsf@gmail.com> <43EF1EEA-BE3B-493A-9BDE-C8AE37B9696A@acm.org> <87lfxxw0p7.fsf@gmail.com> <7B7A7273-8BC9-452E-A10C-C310FED098C4@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="147343"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: Lars Ingebrigtsen , Stefan Monnier , 14769@debbugs.gnu.org, shigeru.fukaya@gmail.com To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 23 00:18:25 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1heoL1-000cAe-1n for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Jun 2019 00:18:23 +0200 Original-Received: from localhost ([::1]:42564 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1heoKz-0000dj-KP for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Jun 2019 18:18:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57675) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1heoKk-0000dW-F2 for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2019 18:18:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1heoKg-0005If-Tg for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2019 18:18:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39089) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1heoKg-0005IM-G4 for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2019 18:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1heoKg-0006n5-7d for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2019 18:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jun 2019 22:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14769-submit@debbugs.gnu.org id=B14769.156124185426055 (code B ref 14769); Sat, 22 Jun 2019 22:18:02 +0000 Original-Received: (at 14769) by debbugs.gnu.org; 22 Jun 2019 22:17:34 +0000 Original-Received: from localhost ([127.0.0.1]:52629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1heoKD-0006mB-R2 for submit@debbugs.gnu.org; Sat, 22 Jun 2019 18:17:34 -0400 Original-Received: from mail-io1-f52.google.com ([209.85.166.52]:37169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1heoKC-0006ly-Hc for 14769@debbugs.gnu.org; Sat, 22 Jun 2019 18:17:33 -0400 Original-Received: by mail-io1-f52.google.com with SMTP id e5so256575iok.4 for <14769@debbugs.gnu.org>; Sat, 22 Jun 2019 15:17:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=SvgMqBJsLBj3tyJQ54JoTwQzbIYkKyjJ9KtdcTF+Ncs=; b=ucYQWn3WtdYCuWkF//LfjrbhVzmj5wpxTMcmW89eCfOBTzJq3EhMVGbUXkFjwkKhKO DrHVLotInN+KR68iIqE3KGz1reVVkZzBGRlsEL5Mev8kbW+UGZVzRUXAjmkgt33Pyde9 72Ajs0sN6nj4WMKstpMpfycRc+fCmdbKbGMtZVWLmB6oKwpGzUJs8lfxY//D771ThYN8 jmYJzLD8kCqUM/6CBT61S9XAdiiHyCcQx5jvsiZeBorrwZIYCy+clnz845/ZRVJP4c9w ebGc9sVlhdpaPhNBnf7Cy2uJ/Uf45RriFm3sYxRW5jcRRAimXNo/kkmA6qbmsPmdSlnt M0xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=SvgMqBJsLBj3tyJQ54JoTwQzbIYkKyjJ9KtdcTF+Ncs=; b=FUW/pRV7s+IIgRlOaJp8LSJsbwx3Ej86/HtIOLH76D/6e7U6cyyBy6iIgbJ/1MNX4F PXeHjr40x5rkJksuW6yUyS7qIDTwLBria4lJWJVpgcjVILCvnxqR1lpXw2uNWNQbc+A2 eMq9Kkb1TAnF3F0V25wcvAyuUh2pL1FFHNF5VNVZJZACOShI08pRXfP8Wo5V4SYb8un/ Alwq3bXGBWboWDieTMBxppom8jmVYvH1haEjpJmy4yYG3LCBcLORCw/hzDRSn+B6oiFf 9CE+dCilguBLdVN0UK9Pmn/X3mCgj4ZuItTUvurZFacuTgykOT+KnprqQH/dtF/1U8YZ IJcQ== X-Gm-Message-State: APjAAAUl9tI/sd1LUrbqu+0DkhbhiE6W8MTtWnM+Y3ZSCDEjPfsl0Qqx s7YGjDMRCcUS9LTVuAkvcJo= X-Google-Smtp-Source: APXvYqw248yipYP+krcL6FL8/P1Ls9eJdyxoJ6KWZYOK5VSAdSR2fINdfHPigT46aoFm7nghZiO0eA== X-Received: by 2002:a02:40c8:: with SMTP id n191mr13915893jaa.14.1561241846832; Sat, 22 Jun 2019 15:17:26 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id z1sm14358763ioh.52.2019.06.22.15.17.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Jun 2019 15:17:26 -0700 (PDT) In-Reply-To: <7B7A7273-8BC9-452E-A10C-C310FED098C4@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Fri, 21 Jun 2019 11:07:13 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161066 Archived-At: Mattias Engdeg=C3=A5rd writes: > 20 juni 2019 kl. 02.38 skrev Noam Postavsky : > >> As a minor aesthetic nitpick, I would suggest using >> `pop', since you're already using `push'. > > Not to the same variable though; it isn't a stack. Okay, interesting. I never considered making that stylistic distinction, I tend to use it on lists freely. > If it's all the same to you, I'd rather keep that part of the code as it = is. Yeah, no problem.