From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#25471: 26.0.50; Edebug and Testcover give incorrect code coverage results for code that uses 'unknown Date: Sat, 27 Jul 2019 12:30:49 +0200 Message-ID: <874l37lqg6.fsf@mouse.gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="99780"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 25471@debbugs.gnu.org To: Gemini Lasswell Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 27 12:31:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrJym-000PpL-HZ for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jul 2019 12:31:08 +0200 Original-Received: from localhost ([::1]:44850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrJyk-00081S-SZ for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jul 2019 06:31:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51589) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrJyh-000819-ID for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 06:31:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hrJyg-0000jQ-28 for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 06:31:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34816) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hrJyf-0000jF-UE for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 06:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hrJyf-0006IX-PO for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 06:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jul 2019 10:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25471 X-GNU-PR-Package: emacs Original-Received: via spool by 25471-submit@debbugs.gnu.org id=B25471.156422345624189 (code B ref 25471); Sat, 27 Jul 2019 10:31:01 +0000 Original-Received: (at 25471) by debbugs.gnu.org; 27 Jul 2019 10:30:56 +0000 Original-Received: from localhost ([127.0.0.1]:43637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrJyZ-0006I4-OX for submit@debbugs.gnu.org; Sat, 27 Jul 2019 06:30:55 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:35718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrJyX-0006Hw-TR for 25471@debbugs.gnu.org; Sat, 27 Jul 2019 06:30:54 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrJyT-0006Fj-Fb; Sat, 27 Jul 2019 12:30:51 +0200 In-Reply-To: (Gemini Lasswell's message of "Tue, 17 Jan 2017 13:24:11 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163834 Archived-At: Gemini Lasswell writes: > If you use Edebug or Testcover to gather code coverage information on > code which uses the symbol `unknown', you will get incorrect code > coverage results, because Edebug uses `unknown' internally to represent > forms which have never been evaluated under Edebug. I've now fixed this in edebug.el on the trunk. > For an example of incorrect code coverage, save this function definition > in a file called bug.el: > > (defun how-do-i-know-you (name) > (let ((val 'unknown)) > (when (equal name "Bob") > (setq val 'known)) > val)) > > And then use: > > M-x testcover-start RET bug.el RET > M-: (how-do-i-know-you "Liz") RET > M-x testcover-mark-all RET RET However, the testcover case seems to be more complicated. `unknown' seems straightforward, but there's also `1value' and `maybe' and perhaps some other symbols that I'm not sure need this or not. `noreturn', for instance, seems part of the official API and can't be changed... I think? I don't use testcover myself. Could you perhaps propose a patch to fix this? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no