From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: 7 logical-xor implementations in source tree Date: Fri, 02 Aug 2019 13:59:59 +0300 Message-ID: <874l2z3k9c.fsf@tcd.ie> References: <87tvbd9a8p.fsf@oremacs.com> <87pnm14u95.fsf@tcd.ie> <87sgqvoz5c.fsf@tcd.ie> <87d0hz2e11.fsf@tcd.ie> <5B633129-B795-4BFA-AE81-FE9FD0A24CE9@acm.org> <0edfffbb-6f5a-a6b2-334a-9000e8f2eb3e@gmail.com> <20190728080417.GA5072@ACM> <875znm3q19.fsf@mbork.pl> <20190730093651.GA5427@ACM> <7n36iny4yq.fsf@ecube.ecubist.org> <7nftmmkz83.fsf@ecube.ecubist.org> <87y30eymw6.fsf@tcd.ie> <674EC692-2EB2-4080-BE91-39DD804B2514@acm.org> <87zhktvko4.fsf@tcd.ie> <989E7E12-52E8-4E45-82A4-997D0988CD1F@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="224614"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Stefan Monnier , Barry Fishman , emacs-devel@gnu.org To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 02 13:00:23 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htVIN-000wHv-6S for ged-emacs-devel@m.gmane.org; Fri, 02 Aug 2019 13:00:23 +0200 Original-Received: from localhost ([::1]:33560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htVIM-0000d4-3L for ged-emacs-devel@m.gmane.org; Fri, 02 Aug 2019 07:00:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47367) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htVIH-0000b3-33 for emacs-devel@gnu.org; Fri, 02 Aug 2019 07:00:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1htVIG-000610-4b for emacs-devel@gnu.org; Fri, 02 Aug 2019 07:00:17 -0400 Original-Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:43994) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1htVIF-0005sf-Mc for emacs-devel@gnu.org; Fri, 02 Aug 2019 07:00:16 -0400 Original-Received: by mail-wr1-x430.google.com with SMTP id p13so2169579wru.10 for ; Fri, 02 Aug 2019 04:00:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=NBH+0Pu89s4DR2KRm6dINkJdZ4lLokgEQL3XhJE4kBk=; b=W3h6YPWl6T3NttDOsYh8tAwr/mJd1654J+JH7+925W/u0Cg1h5QzyLkvrO/T4nFJLI QbDr3ZKW7HZl9qn4DYsS/RDJVFH/sXJuuXHwTJ7F56+DLgX3gJD29h46xQ+yMKAywaEd K0JP8qKlbrFyjau1eF0WmuKH8AmvNAANo7LWulW0n9bkd/rSvsx8ANbP6GJLH1v6rOnH at1n3IfDgbAWnV9GpJHfMQ7xRiQ1xSnvDuAU8OQIbnwr+4egyH5IgNXc0SFrOsYeMD1+ W4L2tPkiUaJNlVf9JEAxP3mJpgStXy2RTHxgbYMDc/RaF/1UIFI36y1ySg+xgS9CgCd6 Gc5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=NBH+0Pu89s4DR2KRm6dINkJdZ4lLokgEQL3XhJE4kBk=; b=RsgzLulX1kWgg/b3eHIeOkeAIcH5qsjanC6kInHV6RiALAXi5ue1pGfVfTdwYP4jdV N9mLmoTu/KlMWkpzN7N1SWQvIEJKI2U7uJQBdqo8Llu1YEXCFPnxMHSsb4b5RU2Y2sPS 3Rm19ppK7F6C/Y/P369mMbsZa8h2X67CIU1vv2HLdh6ZAFc4ZXFPSKmyMrmqZzgiDHe8 Uc37dKqFYmC4C2IDA9o1/wx4rgXhtYwQMUe9LzIiEMcOtJ/L7UC+jwhVUk7CdiX8lKbS 2Kud+43Q0tgpxlBEZr7W/WIe0qge4s/gR66NTAPk4bUlP3aUEuBed3TfH+Rakiru5miO aMKA== X-Gm-Message-State: APjAAAVQ0HaWV/sCc1InYXhTHnELRaIZc81l0a10SUAfsg65iIGD3B/p kao88W9ivHu+mPPagjs1j7wcQQ== X-Google-Smtp-Source: APXvYqxXCgI+Sp/8cpZnt1RyyhK+lBlppS/YMzdlRAVVv/pbBDWqXsMD5LsMv+vOxnMvKYuv3h+S0w== X-Received: by 2002:a5d:65c5:: with SMTP id e5mr7584258wrw.266.1564743613149; Fri, 02 Aug 2019 04:00:13 -0700 (PDT) Original-Received: from localhost (adsl-131.91.140.89.tellas.gr. [91.140.89.131]) by smtp.gmail.com with ESMTPSA id c1sm172626098wrh.1.2019.08.02.04.00.11 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 02 Aug 2019 04:00:12 -0700 (PDT) In-Reply-To: <989E7E12-52E8-4E45-82A4-997D0988CD1F@acm.org> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Fri, 2 Aug 2019 12:29:53 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::430 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239128 Archived-At: Mattias Engdeg=C3=A5rd writes: > 1 aug. 2019 kl. 01.39 skrev Basil L. Contovounesios : >>=20 >> Thanks, LGTM except for some minor nits: > > Thank you! I've fixed them all according to your suggestions, clarified a= few > more things here and there (mentioning the slight change of semantics of = `xor' > in NEWS), and attached the revised patch. > > However, given that the naming and desirability of `equiv' are (amicably) > disputed, I thought it prudent to prepare a reduced patch with `xor' only= , as an > incremental step if nothing else. Either looks and sounds good to me. [Not sure if this is customary, but now that the month has changed, perhaps the log entry could additionally link to the 2019-08 part of this emacs-devel thread.] >>> +(when (equiv enabled disable) >>> + ;; Toggle state >>> + @dots{}) >>=20 >> [I would love to see a better and less forced example than this, BTW.] > > Replaced with another example -- perhaps no better; you be the judge. I prefer your example, it's simpler and needs less explaining. Thanks! --=20 Basil