From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
Barry Fishman <barry@ecubist.org>,
emacs-devel@gnu.org
Subject: Re: 7 logical-xor implementations in source tree
Date: Fri, 02 Aug 2019 13:59:59 +0300 [thread overview]
Message-ID: <874l2z3k9c.fsf@tcd.ie> (raw)
In-Reply-To: <989E7E12-52E8-4E45-82A4-997D0988CD1F@acm.org> ("Mattias Engdegård"'s message of "Fri, 2 Aug 2019 12:29:53 +0200")
Mattias Engdegård <mattiase@acm.org> writes:
> 1 aug. 2019 kl. 01.39 skrev Basil L. Contovounesios <contovob@tcd.ie>:
>>
>> Thanks, LGTM except for some minor nits:
>
> Thank you! I've fixed them all according to your suggestions, clarified a few
> more things here and there (mentioning the slight change of semantics of `xor'
> in NEWS), and attached the revised patch.
>
> However, given that the naming and desirability of `equiv' are (amicably)
> disputed, I thought it prudent to prepare a reduced patch with `xor' only, as an
> incremental step if nothing else.
Either looks and sounds good to me.
[Not sure if this is customary, but now that the month has changed,
perhaps the log entry could additionally link to the 2019-08 part of
this emacs-devel thread.]
>>> +(when (equiv enabled disable)
>>> + ;; Toggle state
>>> + @dots{})
>>
>> [I would love to see a better and less forced example than this, BTW.]
>
> Replaced with another example -- perhaps no better; you be the judge.
I prefer your example, it's simpler and needs less explaining.
Thanks!
--
Basil
next prev parent reply other threads:[~2019-08-02 10:59 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 18:48 7 logical-xor implementations in source tree Oleh Krehel
2019-07-22 21:47 ` Basil L. Contovounesios
2019-07-24 22:17 ` Basil L. Contovounesios
2019-07-24 23:15 ` Stefan Monnier
2019-07-24 23:44 ` Basil L. Contovounesios
2019-07-25 12:07 ` Mattias Engdegård
2019-07-25 17:28 ` Paul Eggert
2019-07-25 17:46 ` Mattias Engdegård
2019-07-28 7:09 ` Philippe Schnoebelen
2019-07-28 8:04 ` Alan Mackenzie
2019-07-28 19:43 ` Marcin Borkowski
2019-07-30 9:36 ` Alan Mackenzie
2019-07-30 10:57 ` Philippe Schnoebelen
2019-07-30 11:28 ` Andy Moreton
2019-07-30 12:34 ` Stefan Monnier
2019-07-30 14:25 ` Barry Fishman
2019-07-31 3:16 ` Richard Stallman
2019-07-31 15:20 ` Barry Fishman
2019-07-31 15:42 ` Stefan Monnier
2019-07-31 20:22 ` Basil L. Contovounesios
2019-07-31 21:15 ` Michael Heerdegen
2019-07-31 22:28 ` Mattias Engdegård
2019-07-31 23:39 ` Basil L. Contovounesios
2019-08-02 10:29 ` Mattias Engdegård
2019-08-02 10:59 ` Basil L. Contovounesios [this message]
2019-08-06 11:58 ` Mattias Engdegård
2019-07-31 20:31 ` Michael Heerdegen
2019-07-31 21:38 ` Drew Adams
2019-07-31 22:03 ` Drew Adams
2019-07-31 22:05 ` Basil L. Contovounesios
2019-07-31 23:20 ` Drew Adams
2019-08-01 0:09 ` Basil L. Contovounesios
2019-07-31 17:12 ` Marcin Borkowski
2019-07-23 8:39 ` Andy Moreton
2019-07-23 9:08 ` Basil L. Contovounesios
2019-07-23 9:14 ` Mattias Engdegård
2019-07-23 10:26 ` Andy Moreton
2019-07-23 10:40 ` Andreas Schwab
2019-07-23 12:11 ` Andy Moreton
2019-07-23 13:20 ` Basil L. Contovounesios
2019-07-23 13:54 ` Andy Moreton
2019-07-24 22:21 ` Basil L. Contovounesios
2019-07-23 10:44 ` Basil L. Contovounesios
2019-07-23 11:01 ` Yuri Khan
2019-07-25 21:46 ` Juri Linkov
2019-07-23 11:24 ` Noam Postavsky
2019-07-23 12:38 ` Stefan Monnier
2019-07-23 16:41 ` Mattias Engdegård
2019-07-23 17:12 ` Eli Zaretskii
2019-07-23 17:48 ` Paul Eggert
2019-07-23 19:45 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874l2z3k9c.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=barry@ecubist.org \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.