all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Lars Ingebrigtsen <larsi@mouse.gnus.org>
Cc: user42_kevin@yahoo.com.au, 19812@debbugs.gnu.org
Subject: bug#19812: 24.4; suggest `shell-mode' not interactive
Date: Wed, 28 Aug 2019 01:13:25 +0300	[thread overview]
Message-ID: <874l22w91a.fsf@mail.linkov.net> (raw)
In-Reply-To: <87v9uod7dy.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Thu, 22 Aug 2019 17:59:05 -0700")

> If I read the comments correctly, nobody had a use case for using `M-x
> shell-mode'.  It was proposed that it could possibly be useful for
> working in log files and the like, but that shell-mode doesn't currently
> actually support that, so I went ahead and applied the patch to disable
> the interactive use of the mode.

I confirm that `M-x shell-mode' can't be used in saved log files.  I tried:

  (defvar shell-log-font-lock-keywords
    ;; `shell-prompt-pattern' can't be used: it finds too many false matches
    '(("^\\([^#$%>\12]*@[^#$%>\12]*:[^#$%>\12]*[#$%>] *\\)\\(.*\\)$"
       (1 'comint-highlight-prompt)
       (2 'comint-highlight-input)))
    "Shell prompts to highlight in Shell Log mode.")

  (define-derived-mode shell-log-mode shell-mode "Shell-Log"
    "Font-lock for shell logs."
    (put 'shell-log-mode 'mode-class nil)
    (setq-local font-lock-defaults '(shell-log-font-lock-keywords t)))

  (add-to-list 'auto-mode-alist '("\\.log\\'" . shell-log-mode))

but `shell-prompt-pattern' matches too many false positives, and
replacing it with a customized regexp is too ad-hoc and unreliable.





      reply	other threads:[~2019-08-27 22:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-08  4:07 bug#19812: 24.4; suggest `shell-mode' not interactive Kevin Ryde
2019-08-02 19:52 ` Lars Ingebrigtsen
2019-08-02 23:54   ` Kevin Ryde
2019-08-03 11:11     ` Lars Ingebrigtsen
2019-08-03  7:22   ` Eli Zaretskii
2019-08-03 11:08     ` Lars Ingebrigtsen
2019-08-04 19:11       ` Juri Linkov
2019-08-05  8:54         ` Kevin Ryde
2019-08-05 21:59           ` Juri Linkov
2019-08-07  6:46             ` Kevin Ryde
2019-08-23  0:59     ` Lars Ingebrigtsen
2019-08-27 22:13       ` Juri Linkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874l22w91a.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=19812@debbugs.gnu.org \
    --cc=larsi@mouse.gnus.org \
    --cc=user42_kevin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.