From: Stefan Kangas <stefan@marxist.se>
To: "João Távora" <joaotavora@gmail.com>
Cc: Damien Cassou <damien@cassou.me>,
38284@debbugs.gnu.org, Nicolas Petton <nicolas@petton.fr>
Subject: bug#38284: 27.0.50; [PATCH] Make auth-source-pass-search understand port lists
Date: Mon, 20 Jan 2020 19:54:01 +0100 [thread overview]
Message-ID: <874kwqt0vq.fsf@marxist.se> (raw)
In-Reply-To: <87lfs8b6dx.fsf@gmail.com> ("João Távora"'s message of "Fri, 22 Nov 2019 09:35:38 +0000")
João Távora <joaotavora@gmail.com> writes:
> Damien Cassou <damien@cassou.me> writes:
>
>> Can you please merge the attached patch with yours?
>
> No, but you can do that, because it's your work (I can push it for you
> though). Anyway, now I read the test you wrote, I agree it's a good
> test. You are testing auth-source-pass-match-entry-p, much higher up
> than auth-source-pass--generate-entry-suffixes, the function I changed.
>
> Of course, only someone who was involved in the design would be able to
> confidently place the tests at that correct level, the finding of which
> is the most difficult part.
If the test is good, I think it should be installed. Unfortunately,
it seems like it doesn't apply cleanly to current master.
Damien, could you please re-send the patch formatted by "git
format-patch -1"? Please also include a commit message with a
ChangeLog entry as described in the CONTRIBUTE file.
Best regards,
Stefan Kangas
next prev parent reply other threads:[~2020-01-20 18:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 0:20 bug#38284: 27.0.50; [PATCH] Make auth-source-pass-search understand port lists João Távora
2019-11-21 13:47 ` Lars Ingebrigtsen
2019-11-21 18:27 ` Damien Cassou
2019-11-21 19:06 ` João Távora
2019-11-22 8:49 ` Damien Cassou
2019-11-22 9:35 ` João Távora
2020-01-20 18:54 ` Stefan Kangas [this message]
2020-01-21 19:25 ` Damien Cassou
2020-01-22 8:02 ` Stefan Kangas
2020-01-22 9:22 ` Damien Cassou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kwqt0vq.fsf@marxist.se \
--to=stefan@marxist.se \
--cc=38284@debbugs.gnu.org \
--cc=damien@cassou.me \
--cc=joaotavora@gmail.com \
--cc=nicolas@petton.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.