From: Damien Cassou <damien@cassou.me>
To: "Stefan Kangas" <stefan@marxist.se>,
"João Távora" <joaotavora@gmail.com>
Cc: 38284@debbugs.gnu.org, Nicolas Petton <nicolas@petton.fr>
Subject: bug#38284: 27.0.50; [PATCH] Make auth-source-pass-search understand port lists
Date: Tue, 21 Jan 2020 20:25:08 +0100 [thread overview]
Message-ID: <874kwo6297.fsf@cassou.me> (raw)
In-Reply-To: <874kwqt0vq.fsf@marxist.se>
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
Stefan Kangas <stefan@marxist.se> writes:
> If the test is good, I think it should be installed. Unfortunately,
> it seems like it doesn't apply cleanly to current master.
>
> Damien, could you please re-send the patch formatted by "git
> format-patch -1"? Please also include a commit message with a
> ChangeLog entry as described in the CONTRIBUTE file.
The patch was only meant to be added to João's own patch. Here is a
standalone one.
--
Damien Cassou
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-test-lisp-auth-source-pass-tests.el-Test-for-multipl.patch --]
[-- Type: text/x-patch, Size: 1194 bytes --]
From 7e4c1aaa934f155e3aa3c69ba0a3460c1b6b90f3 Mon Sep 17 00:00:00 2001
From: Damien Cassou <damien@cassou.me>
Date: Tue, 21 Jan 2020 20:13:54 +0100
Subject: [PATCH] * test/lisp/auth-source-pass-tests.el: Test for multiple
ports.
---
test/lisp/auth-source-pass-tests.el | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/test/lisp/auth-source-pass-tests.el b/test/lisp/auth-source-pass-tests.el
index 10ed9c39fb..677abb33cc 100644
--- a/test/lisp/auth-source-pass-tests.el
+++ b/test/lisp/auth-source-pass-tests.el
@@ -353,6 +353,10 @@ auth-source-pass--matching-entries-find-entries-with-a-port
(auth-source-pass--with-store '(("bar.com:8080"))
(should (auth-source-pass-match-entry-p "bar.com:8080" "bar.com" nil "8080"))))
+(ert-deftest auth-source-pass--matching-entries-find-entries-with-a-port-when-passed-multiple-ports ()
+ (auth-source-pass--with-store '(("bar.com:8080"))
+ (should (auth-source-pass-match-entry-p "bar.com:8080" "bar.com" nil '("http" "https" "80" "8080")))))
+
(ert-deftest auth-source-pass--matching-entries-find-entries-with-slash ()
;; match if entry filename matches user
(auth-source-pass--with-store '(("foo.com/user"))
--
2.24.1
next prev parent reply other threads:[~2020-01-21 19:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 0:20 bug#38284: 27.0.50; [PATCH] Make auth-source-pass-search understand port lists João Távora
2019-11-21 13:47 ` Lars Ingebrigtsen
2019-11-21 18:27 ` Damien Cassou
2019-11-21 19:06 ` João Távora
2019-11-22 8:49 ` Damien Cassou
2019-11-22 9:35 ` João Távora
2020-01-20 18:54 ` Stefan Kangas
2020-01-21 19:25 ` Damien Cassou [this message]
2020-01-22 8:02 ` Stefan Kangas
2020-01-22 9:22 ` Damien Cassou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kwo6297.fsf@cassou.me \
--to=damien@cassou.me \
--cc=38284@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=nicolas@petton.fr \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.