From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 34949@debbugs.gnu.org
Subject: bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete
Date: Wed, 25 Mar 2020 22:59:06 +0200 [thread overview]
Message-ID: <874kuci4tx.fsf@mail.linkov.net> (raw)
In-Reply-To: <87y2rpqt28.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 25 Mar 2020 00:36:15 +0200")
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
>> Are you sure you don't want to split it into a new command that will simply
>> mark a set of files you expect here? E.g. all belonging to "registered"
>> statuses. That might require extra keypress, but vc-dir-root-registered is
>> probably not going to have the same short combination that vc-dir has
>> anyway. So it might be a wash, keypresses-wise.
>
> VC-Dir needs the same key prefix as is provided by Dired:
>
> * % dired-mark-files-regexp
> * * dired-mark-executables
> * / dired-mark-directories
> * ? dired-unmark-all-files
> * @ dired-mark-symlinks
> * s dired-mark-subdir-files
>
> Then VC-Dir could provide, for example:
>
> * r vc-dir-mark-registered
> * u vc-dir-mark-unregistered
> ...
This is implemented as well:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: vc-dir-mark-state-files.patch --]
[-- Type: text/x-diff, Size: 2178 bytes --]
diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el
index 38b4937e85..87b6b3b547 100644
--- a/lisp/vc/vc-dir.el
+++ b/lisp/vc/vc-dir.el
@@ -147,6 +147,12 @@ vc-dir-menu-map
'(menu-item "Unmark Previous " vc-dir-unmark-file-up
:help "Move to the previous line and unmark the file"))
+ (define-key map [mark-unregistered]
+ '(menu-item "Mark Unregistered" vc-dir-mark-unregistered-files
+ :help "Mark all files in the unregistered state"))
+ (define-key map [mark-registered]
+ '(menu-item "Mark Registered" vc-dir-mark-registered-files
+ :help "Mark all files in the state edited, added or removed"))
(define-key map [mark-all]
'(menu-item "Mark All" vc-dir-mark-all-files
:help "Mark all files that are in the same state as the current file\
@@ -310,6 +316,11 @@ vc-dir-mode-map
(define-key branch-map "l" 'vc-print-branch-log)
(define-key branch-map "s" 'vc-retrieve-tag))
+ (let ((mark-map (make-sparse-keymap)))
+ (define-key map "*" mark-map)
+ (define-key mark-map "r" 'vc-dir-mark-registered-files)
+ (define-key mark-map "u" 'vc-dir-mark-unregistered-files))
+
;; Hook up the menu.
(define-key map [menu-bar vc-dir-mode]
`(menu-item
@@ -696,6 +707,27 @@ vc-dir-mark-all-files
(vc-dir-mark-file crt)))
(setq crt (ewoc-next vc-ewoc crt))))))))
+(defun vc-dir-mark-state-files (states)
+ "Mark files that are in the state specified by the list in STATES."
+ (unless (listp states)
+ (setq states (list states)))
+ (ewoc-map
+ (lambda (filearg)
+ (when (memq (vc-dir-fileinfo->state filearg) states)
+ (setf (vc-dir-fileinfo->marked filearg) t)
+ t))
+ vc-ewoc))
+
+(defun vc-dir-mark-registered-files ()
+ "Mark files that are in one of registered state: edited, added or removed."
+ (interactive)
+ (vc-dir-mark-state-files '(edited added removed)))
+
+(defun vc-dir-mark-unregistered-files ()
+ "Mark files that are in unregistered state."
+ (interactive)
+ (vc-dir-mark-state-files 'unregistered))
+
(defun vc-dir-unmark-file ()
;; Unmark the current file and move to the next line.
(let* ((crt (ewoc-locate vc-ewoc))
next prev parent reply other threads:[~2020-03-25 20:59 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 17:50 bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete Philipp Stephani
2019-10-09 22:40 ` Lars Ingebrigtsen
2019-12-24 19:53 ` Dmitry Gutov
2019-12-24 23:28 ` Juri Linkov
2020-02-17 23:42 ` Juri Linkov
2020-02-18 22:27 ` Dmitry Gutov
2020-02-18 23:36 ` Juri Linkov
2020-02-20 23:14 ` Juri Linkov
2020-02-21 0:22 ` Dmitry Gutov
2020-02-23 0:04 ` Juri Linkov
2020-02-23 9:01 ` Dmitry Gutov
2020-02-23 23:25 ` Juri Linkov
2020-02-24 0:17 ` Dmitry Gutov
2020-02-25 0:12 ` Juri Linkov
2020-02-25 10:32 ` Dmitry Gutov
2020-02-25 21:23 ` Juri Linkov
2020-02-26 22:49 ` Dmitry Gutov
2020-02-26 23:46 ` Juri Linkov
2020-02-27 7:28 ` Dmitry Gutov
2020-02-27 23:15 ` Juri Linkov
2020-02-28 19:22 ` Dmitry Gutov
2020-02-29 21:25 ` Juri Linkov
2020-02-29 22:25 ` Dmitry Gutov
2020-03-09 22:55 ` Juri Linkov
2020-03-12 0:08 ` Dmitry Gutov
2020-03-12 0:41 ` Juri Linkov
2020-03-12 22:43 ` Juri Linkov
2020-03-13 12:11 ` Dmitry Gutov
2020-03-14 23:31 ` Juri Linkov
2020-03-15 21:54 ` Dmitry Gutov
2020-03-15 23:58 ` Juri Linkov
2020-03-16 20:17 ` Dmitry Gutov
2020-03-24 22:16 ` Juri Linkov
2020-03-25 20:47 ` Juri Linkov
2020-03-25 21:32 ` Dmitry Gutov
2020-03-29 22:35 ` Juri Linkov
2020-03-30 19:53 ` Dmitry Gutov
2020-03-24 22:36 ` Juri Linkov
2020-03-25 20:59 ` Juri Linkov [this message]
2020-03-25 21:15 ` Drew Adams
2020-03-25 21:50 ` Juri Linkov
2020-03-25 22:04 ` Drew Adams
2020-03-26 23:18 ` Juri Linkov
2020-03-27 16:11 ` Drew Adams
2020-03-27 22:41 ` Dmitry Gutov
2020-03-28 23:54 ` Juri Linkov
2020-03-29 18:41 ` Dmitry Gutov
2020-03-29 22:27 ` Juri Linkov
2020-03-30 20:01 ` Dmitry Gutov
2020-03-30 22:40 ` Juri Linkov
2020-03-30 23:22 ` Dmitry Gutov
2020-03-31 1:02 ` Drew Adams
2020-04-02 22:08 ` Juri Linkov
2020-04-03 0:21 ` Dmitry Gutov
2020-04-03 20:08 ` Philipp Stephani
2020-04-04 23:37 ` Juri Linkov
2020-04-05 9:47 ` Philipp Stephani
2020-04-05 23:05 ` Juri Linkov
2020-04-09 8:41 ` Eli Zaretskii
2020-04-11 23:38 ` Juri Linkov
2020-04-12 6:33 ` Eli Zaretskii
2020-04-12 23:51 ` Juri Linkov
2020-04-13 4:31 ` Eli Zaretskii
2020-04-13 23:25 ` Juri Linkov
2020-03-25 21:59 ` Dmitry Gutov
2020-03-26 23:10 ` Juri Linkov
2020-03-26 23:51 ` Dmitry Gutov
2020-02-21 0:16 ` Dmitry Gutov
2019-12-25 21:45 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kuci4tx.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=34949@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.