bug#41745: 28.0.50; problem with json file and which-function on pretest an master

bug#41745: 28.0.50; problem with json file and which-function on pretest an master

[Andrés Ramírez]

Hi.

I have an issue after opening a json file with pretest.  Going to end of file with M-> then M-x backward-delete-char. I get
this:

--8<---------------cut here---------------start------------->8---
Debugger entered--Lisp error: (cl-assertion-failed ((or (= (point-min) (point-max)) (eq js--last-parse-pos (point))) nil))
  cl--assertion-failed((or (= (point-min) (point-max)) (eq js--last-parse-pos (point))))
  js--imenu-create-index()
  imenu--make-index-alist(t)
  which-function()
  which-func-update-1(#<window 3 on sale_line_grammar.json>)
  which-func-update()
  apply(which-func-update nil)
  timer-event-handler([t 0 0 500000 t which-func-update nil idle 0])
--8<---------------cut here---------------end--------------->8---

I have tried to do the same with emacs -Q (But. I was not able of
reproducing it).

Also I have tested the same with emacs26.3. And everything works ok.

So my personal conclusion is that this is a regression (related to which-func.el).

So. I have not been able of reproducing it with emacs -Q. If needed I
could share my dot emacs files.

Just in Case this is the content of the file that causes the issue:

--8<---------------cut here---------------start------------->8---
//  TODO: code the #else; analize  it {before document better the keywords}
#if ( ${saleline.is_service()} == 0 )
${saleline.supplier()}/${saleline.subcategory()}/${saleline.color()}/${saleline.size()}/${saleline.name()}/${saleline.unit()}
#end
#if ( ${saleline.is_service()} == "1" )
${saleline.supplier()}/${saleline.subcategory()}/${saleline.name()}
#end
--8<---------------cut here---------------end--------------->8---

Best Regards



In GNU Emacs 28.0.50 (build 2, armv7l-unknown-linux-gnueabihf, GTK+ Version 3.24.20, cairo version 1.17.3)
Repository revision: a69ef94e22716f9cbb7cf8d78b89e7be4a4c60eb
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Arch Linux ARM

Recent messages:
Loading /home/olla/.emacs.d/init.el (source)...done
Loading /home/olla/.emacs.d/elpa/god-mode/god-mode.el (source)...done
Loading /home/olla/.emacs.d/elpa/avy/avy.el (source)...done
Loading /home/olla/.emacs.d/elpa/ace-window/ace-window.el (source)...done
Loading /home/olla/.emacs.d/my-noexternals.el (source)...
Created wl link.
loading my-noexternal not dot file
restoring gc-cons-threshold after startup
Loading /home/olla/.emacs.d/my-noexternals.el (source)...done
Package cl is deprecated

Configured using:
 'configure '--program-transform-name=s/^ctags$/ctags.emacs/'
 --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
 --localstatedir=/usr/share --with-x-toolkit=gtk --mandir=/usr/share/man
 --pdfdir=/usr/share/doc/emacs --with-modules --with-xft --without-gconf
 --without-gsettings --with-imagemagick --without-xwidgets --without-pop
 --with-gameuser=:games --disable-build-details 'CFLAGS=-march=armv7-a
 -mfloat-abi=hard -mfpu=vfpv3-d16 -O2 -pipe -fstack-protector-strong
 -fno-plt -g3 -Og
 -fdebug-prefix-map=/home/user/abs/emacs-gtk-85715/src=/usr/src/debug'
 CPPFLAGS=-D_FORTIFY_SOURCE=2
 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now'

Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO IMAGEMAGICK SOUND GPM DBUS GLIB NOTIFY
INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON
PDUMPER LCMS2 GMP

Important settings:
  value of $LC_COLLATE: C
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  display-time-mode: t
  which-function-mode: t
  savehist-mode: t
  show-paren-mode: t
  erc-track-mode: t
  erc-match-mode: t
  erc-autojoin-mode: t
  erc-fill-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs
text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils tron-theme add-log my-noexternals server
time org-wl org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro
org-footnote org-src ob-comint org-pcomplete pcomplete comint ansi-color
org-list org-faces org-entities time-date noutline outline org-version
ob-emacs-lisp ob-core ob-eval org-table ol org-keys org-compat org-macs
org-loaddefs find-func cal-menu calendar cal-loaddefs sm-c-mode derived
pcase smie netrc ace-window avy ring god-mode emms-get-lyrics mbsync rx
my-misc-setup ido which-func savehist paren vc-git diff-mode easy-mmode
em-alias em-smart esh-mode esh-cmd esh-ext esh-opt esh-proc esh-io
esh-arg esh-module esh-groups esh-util my-erc-setup erc-services
erc-networks erc-track erc-match erc-sasl cl erc-menu erc-join erc-fill
erc-stamp erc-goodies erc erc-backend erc-compat format-spec auth-source
cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json
subr-x map seq byte-opt gv bytecomp byte-compile cconv pp erc-loaddefs
my-defuns-setup imenu thingatpt info-look info google-c-style gtags
cc-mode cc-fonts easymenu cc-guess cc-menus cc-cmds cc-styles cc-align
cc-engine cc-vars cc-defs edmacro kmacro cl-loaddefs cl-lib jka-compr
advice lemacs-public tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote threads dbusbind
inotify lcms2 dynamic-setting font-render-setting cairo move-toolbar gtk
x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 8 194069 156217)
 (symbols 24 20498 1)
 (strings 16 63580 8303)
 (string-bytes 1 2150082)
 (vectors 8 27826)
 (vector-slots 4 327386 154564)
 (floats 8 101 627)
 (intervals 28 316 0)
 (buffers 576 10))

bug#41745: 28.0.50; problem with json file and which-function on pretest an master

[Basil L. Contovounesios]

Andrés Ramírez <rrandresf@gmail.com> writes:

> I have an issue after opening a json file with pretest.  Going to end
> of file with M-> then M-x backward-delete-char. I get this:
>
> Debugger entered--Lisp error: (cl-assertion-failed ((or (= (point-min) (point-max)) (eq js--last-parse-pos (point))) nil))
>   cl--assertion-failed((or (= (point-min) (point-max)) (eq js--last-parse-pos (point))))
>   js--imenu-create-index()
>   imenu--make-index-alist(t)
>   which-function()
>   which-func-update-1(#<window 3 on sale_line_grammar.json>)
>   which-func-update()
>   apply(which-func-update nil)
>   timer-event-handler([t 0 0 500000 t which-func-update nil idle 0])
>
> I have tried to do the same with emacs -Q (But. I was not able of
> reproducing it).

Could you try commenting-out parts of your configuration, perhaps by
recursively bisecting it, to narrow down which parts of it give rise to
the error?

> Also I have tested the same with emacs26.3. And everything works ok.
>
> So my personal conclusion is that this is a regression (related to which-func.el).

That depends on who is causing the problem - it could be a third-party
package that you have installed, for example.  Until there is a clear
reproduction recipe it's hard to know for sure.

> So. I have not been able of reproducing it with emacs -Q. If needed I
> could share my dot emacs files.
>
> Just in Case this is the content of the file that causes the issue:
>
> //  TODO: code the #else; analize  it {before document better the keywords}
> #if ( ${saleline.is_service()} == 0 )
> ${saleline.supplier()}/${saleline.subcategory()}/${saleline.color()}/${saleline.size()}/${saleline.name()}/${saleline.unit()}
> #end
> #if ( ${saleline.is_service()} == "1" )
> ${saleline.supplier()}/${saleline.subcategory()}/${saleline.name()}
> #end

I'm confused; are these the entire contents of the file
sale_line_grammar.json that is mentioned in the backtrace?  Is this some
sort of templating syntax that is replaced with valid JSON later on?  If
so, this issue is more about js-mode or whichever other major mode you
may be using, rather than JSON.  What does C-h v major-mode RET tell you
when you're visiting this file?

I tried the following with both emacs-27 and master and didn't run into
any errors:

0. emacs -Q
1. C-x C-f /tmp/sale_line_grammar.json RET
2. M->
3. M-x delete-backward-char RET
4. C-x z z z z z z z z

-- 
Basil

bug#41745: 28.0.50; problem with json file and which-function on pretest an master

[Dmitry Gutov]

On 07.06.2020 15:23, Basil L. Contovounesios wrote:
> I'm confused; are these the entire contents of the file
> sale_line_grammar.json that is mentioned in the backtrace?  Is this some
> sort of templating syntax that is replaced with valid JSON later on?

That is indeed a bit surprising to see in a JSON file. But if it worked 
before...

> If
> so, this issue is more about js-mode or whichever other major mode you
> may be using, rather than JSON.

Emacs associates js-mode with .json files. json-mode is in ELPA only.

bug#41745: 28.0.50; problem with json file and which-function on pretest an master

[Basil L. Contovounesios]

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 07.06.2020 15:23, Basil L. Contovounesios wrote:
>> I'm confused; are these the entire contents of the file
>> sale_line_grammar.json that is mentioned in the backtrace?  Is this some
>> sort of templating syntax that is replaced with valid JSON later on?
>
> That is indeed a bit surprising to see in a JSON file. But if it worked
> before...

That's not saying enough, because it could be that some external code
does not support Emacs 27+ properly.

>> If
>> so, this issue is more about js-mode or whichever other major mode you
>> may be using, rather than JSON.
>
> Emacs associates js-mode with .json files. json-mode is in ELPA only.

I know, but details about which modes are in use are missing from the
bug report.

-- 
Basil

bug#41745: 28.0.50; problem with json file and which-function on pretest an master

[andrés ramírez]

Hi Basil. Hi Dmitry.

>>>>> "Basil" == Basil L Contovounesios <contovob@tcd.ie> writes:

    Basil> Dmitry Gutov <dgutov@yandex.ru> writes:
    >> On 07.06.2020 15:23, Basil L. Contovounesios wrote:
    >>> I'm confused; are these the entire contents of the file sale_line_grammar.json that is
    >>> mentioned in the backtrace?  Is this some sort of templating syntax that is replaced with
    >>> valid JSON later on?
    >> 
    >> That is indeed a bit surprising to see in a JSON file. But if it worked before...

    Basil> That's not saying enough, because it could be that some external code does not support
    Basil> Emacs 27+ properly.

Actually I have a bash script for testing my dot emacs without any
external package:
--8<---------------cut here---------------start------------->8---
emacs --no-bitmap-icon -Q --eval " (progn (defvar
my-cli-not-init-pkgs-flag t \"v=how emacs start\") (load
\"~/.emacs.d/init.el\") )"
--8<---------------cut here---------------end--------------->8---

See the result (with external packages isolated):
--8<---------------cut here---------------start------------->8---
http://0x0.st/iVZu.png
--8<---------------cut here---------------end--------------->8---

Best Regards

bug#41745: 28.0.50; problem with json file and which-function on pretest an master

[andrés ramírez]

Hi Basil.

>>>>> "Basil" == Basil L Contovounesios <contovob@tcd.ie> writes:


    Basil> Could you try commenting-out parts of your configuration, perhaps by recursively
    Basil> bisecting it, to narrow down which parts of it give rise to the error?

Yes. I Could. And probably I am goint to do so. I the meanttime I just
change to fundamental-mode or visit-file-literally. 

    Basil> I'm confused; are these the entire contents of the file sale_line_grammar.json that is
    Basil> mentioned in the backtrace?

Yes. It is the entire content.

    Basil> Is this some sort of templating syntax that is replaced with
    Basil> valid JSON later on?

Yes. It is. I have a parser(yacc|bison) that does the job.

    Basil>If so, this issue is more about js-mode or whichever other major
    Basil> mode you may be using, rather than JSON.  What does C-h v major-mode RET tell you when
    Basil> you're visiting this file?

--8<---------------cut here---------------start------------->8---
http://0x0.st/iVZc.png
--8<---------------cut here---------------end--------------->8---

    Basil> I tried the following with both emacs-27 and master and didn't run into any errors:

    Basil> 0. emacs -Q 1. C-x C-f /tmp/sale_line_grammar.json RET 2. M-> 3. M-x delete-backward-char
    Basil> RET 4. C-x z z z z z z z z

Thanks fro trying it.

Best

bug#41745: 28.0.50; problem with json file and which-function on pretest an master

[Basil L. Contovounesios]

andrés ramírez <rrandresf@gmail.com> writes:

>>>>>> "Basil" == Basil L Contovounesios <contovob@tcd.ie> writes:
>
>     Basil> I'm confused; are these the entire contents of the file sale_line_grammar.json that is
>     Basil> mentioned in the backtrace?
>
> Yes. It is the entire content.
>
>     Basil> Is this some sort of templating syntax that is replaced with
>     Basil> valid JSON later on?
>
> Yes. It is. I have a parser(yacc|bison) that does the job.

So it's a custom syntax?  Then why do you expect js-mode to support it?

-- 
Basil

bug#41745: 28.0.50; problem with json file and which-function on pretest an master

[andrés ramírez]

Hi Basil.
>>>>> "Basil" == Basil L Contovounesios <contovob@tcd.ie> writes:


    Basil> So it's a custom syntax?  Then why do you expect js-mode to support it?

Because It was working on the previous version 26.3.

Best Regards

bug#41745: 28.0.50; problem with json file and which-function on pretest an master

[Basil L. Contovounesios]

andrés ramírez <rrandresf@gmail.com> writes:

>>>>>> "Basil" == Basil L Contovounesios <contovob@tcd.ie> writes:
>
>     Basil> So it's a custom syntax?  Then why do you expect js-mode to support it?
>
> Because It was working on the previous version 26.3.

If it's not a syntax that js-mode officially supports, then the fact
that it worked in 26.3 is just a happy coincidence, and not something
that has to be maintained.

Unless you or someone else can confirm that this is supported syntax, I
don't see a bug here.  The reason I'm not sure is because I'm not
familiar with js-mode and the different flavours of JS-like syntax that
are meant to be supported.

-- 
Basil

bug#41745: 28.0.50; problem with json file and which-function on pretest an master

[andrés ramírez]

Hi. Basil.

>>>>> "Basil" == Basil L Contovounesios <contovob@tcd.ie> writes:


    Basil> If it's not a syntax that js-mode officially supports, then the fact that it worked in
    Basil> 26.3 is just a happy coincidence, and not something that has to be maintained.

Right. You have a point.

    Basil> Unless you or someone else can confirm that this is supported syntax, I don't see a bug
    Basil> here.  The reason I'm not sure is because I'm not familiar with js-mode and the different
    Basil> flavours of JS-like syntax that are meant to be supported.

Then I see two paths:

1. Dismiss the bug support. Because this is a feature not a bug.
2. Find a way to inhibit it. Cos It just triggers a message when doing
the bacward-delete-char. Perhaps with a var.

Thanks for working on this. Feel free to close this report in case of number 1.

Best Regards and sorry for the noise

bug#41745: 28.0.50; problem with json file and which-function on pretest an master

[Basil L. Contovounesios]

andrés ramírez <rrandresf@gmail.com> writes:

> Hi. Basil.
>
>>>>>> "Basil" == Basil L Contovounesios <contovob@tcd.ie> writes:
>
>
>     Basil> If it's not a syntax that js-mode officially supports, then the fact that it worked in
>     Basil> 26.3 is just a happy coincidence, and not something that has to be maintained.
>
> Right. You have a point.
>
>     Basil> Unless you or someone else can confirm that this is supported syntax, I don't see a bug
>     Basil> here.  The reason I'm not sure is because I'm not familiar with js-mode and the different
>     Basil> flavours of JS-like syntax that are meant to be supported.
>
> Then I see two paths:
>
> 1. Dismiss the bug support. Because this is a feature not a bug.
> 2. Find a way to inhibit it. Cos It just triggers a message when doing
> the bacward-delete-char. Perhaps with a var.
>
> Thanks for working on this. Feel free to close this report in case of number 1.

I didn't work on anything. ;)

> Best Regards and sorry for the noise

No worries, I'll leave the report open in case anyone wants to look into
it.

-- 
Basil

bug#41745: 28.0.50; problem with json file and which-function on pretest an master

[Dmitry Gutov]

On 07.06.2020 22:11, Basil L. Contovounesios wrote:
> Unless you or someone else can confirm that this is supported syntax, I
> don't see a bug here.  The reason I'm not sure is because I'm not
> familiar with js-mode and the different flavours of JS-like syntax that
> are meant to be supported.

It's probably not an officially supported use, but if somebody has spare 
time, perhaps they could look into what caused this particular breakage.

The error condition seems general enough, not dependent on the exact 
contents of the file.

bug#41745: 28.0.50; problem with json file and which-function on pretest an master

[Basil L. Contovounesios]

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 07.06.2020 22:11, Basil L. Contovounesios wrote:
>> Unless you or someone else can confirm that this is supported syntax, I
>> don't see a bug here.  The reason I'm not sure is because I'm not
>> familiar with js-mode and the different flavours of JS-like syntax that
>> are meant to be supported.
>
> It's probably not an officially supported use, but if somebody has spare time,
> perhaps they could look into what caused this particular breakage.

Sure, I'm in no hurry to close the issue.

> The error condition seems general enough, not dependent on the exact contents of
> the file.

Really?  Looks to me like it barfs when trying to parse the buffer
contents for imenu entries.

-- 
Basil

bug#41745: 28.0.50; problem with json file and which-function on pretest an master

[Dmitry Gutov]

On 07.06.2020 23:34, Basil L. Contovounesios wrote:
> Really?  Looks to me like it barfs when trying to parse the buffer
> contents for imenu entries.

   (or (= (point-min) (point-max)) (eq js--last-parse-pos (point)))

That's a pretty general condition.

bug#41745: 28.0.50; problem with json file and which-function on pretest an master

[Lars Ingebrigtsen]

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> If it's not a syntax that js-mode officially supports, then the fact
> that it worked in 26.3 is just a happy coincidence, and not something
> that has to be maintained.
>
> Unless you or someone else can confirm that this is supported syntax, I
> don't see a bug here.  The reason I'm not sure is because I'm not
> familiar with js-mode and the different flavours of JS-like syntax that
> are meant to be supported.

(I'm going through old bug reports that unfortunately weren't resolved
at the time.)

Skimming this bug report, it seems the conclusion is that this isn't a
bug, so I'm therefore closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no