From: "Philip K." <philip@warpmail.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 41619@debbugs.gnu.org
Subject: bug#41619: [PATCH] Mark python-shell-virtualenv-root as safe local variable
Date: Tue, 16 Jun 2020 19:32:52 +0200 [thread overview]
Message-ID: <874krark57.fsf@warpmail.net> (raw)
In-Reply-To: <83ftav0w11.fsf@gnu.org> (message from Eli Zaretskii on Tue, 16 Jun 2020 20:18:18 +0300)
Eli Zaretskii <eliz@gnu.org> writes:
>> From: "Philip K." <philip@warpmail.net>
>> Cc: rgm@gnu.org, 41619@debbugs.gnu.org
>> Date: Tue, 16 Jun 2020 18:52:07 +0200
>>
>> Ultimatly, my estimation was wrong, and the variable shouldn't be marked
>> as safe, at least not with any heuristics that could warn the user if
>> the path is suspicious.
>
> So all we need is to remove the :safe attribute from the variable? Or
> something else?
That would make it harder for projects to hide malicious values of
python-shell-virtualenv-root, but it's still an attack vector in
principle.
--
Philip K.
next prev parent reply other threads:[~2020-06-16 17:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 20:31 bug#41619: [PATCH] Mark python-shell-virtualenv-root as safe local variable Philip K.
2020-06-13 7:42 ` Eli Zaretskii
2020-06-13 17:20 ` Glenn Morris
2020-06-15 18:53 ` Eli Zaretskii
2020-06-16 16:52 ` Philip K.
2020-06-16 17:18 ` Eli Zaretskii
2020-06-16 17:32 ` Philip K. [this message]
2020-06-16 17:54 ` Eli Zaretskii
2020-06-16 19:49 ` Philip K.
2020-06-20 8:47 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874krark57.fsf@warpmail.net \
--to=philip@warpmail.net \
--cc=41619@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.