all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Byte-compilation warning in eldoc.el
Date: Fri, 10 Jul 2020 08:20:37 +0100	[thread overview]
Message-ID: <874kqfg7ju.fsf@gmail.com> (raw)
In-Reply-To: <83k0zbq2sd.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 Jul 2020 09:53:22 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>   In toplevel form:
>   emacs-lisp/eldoc.el:540:2: Warning: unintern called with 1 argument, but
>       requires 2

Thanks, fixed.  But curiously it doesn't.  You can call it (and I always
do call it) with one argument, as one does in CL.

By the way, the only reason I had to do this (I rarely use this outside
interactive contexts) is to make eldoc.el work in Emacs 26.3.  I explain
this in the commit message, but I'm still uncertain of the cause of the
problem:

Author: João Távora <joaotavora@gmail.com>
Date:   Fri Jul 10 01:47:10 2020 +0100

    Fix Eldoc problem when loading on Emacs 26.3
    
    When defining the obsolete variable alias for old
    eldoc-documentation-function (which now points to the newer
    eldoc-documentation-strategy), one gets the error "don't know how to
    make a localized vareiable an alias".  I'm not sure, but I suspect
    this is because Eldoc is preloaded in Emacs 26.3 and the
    eldoc-documentation-function variable is already set locally by some
    Elisp buffer.
    
    Uninterning the symbol shortly before defining the alias seems to fix
    it.

Separately, I also noticed that calling `package-install` for Eldoc in
Emacs 26.3, will _not_ load eldoc, and neither will `require`.  One has
to `load` it specifically, even after calling `package-initialize`.

João



  reply	other threads:[~2020-07-10  7:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-10  6:53 Byte-compilation warning in eldoc.el Eli Zaretskii
2020-07-10  7:20 ` João Távora [this message]
2020-07-10  7:43   ` Eli Zaretskii
2020-07-10  9:36   ` Noam Postavsky
2020-07-10 14:41   ` Stefan Monnier
2020-07-10 15:05     ` Drew Adams
2020-07-10 15:31     ` João Távora
2020-07-10 21:29       ` Stefan Monnier
2020-07-10 21:48         ` João Távora
2020-07-10 22:08           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kqfg7ju.fsf@gmail.com \
    --to=joaotavora@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.