bug#13492: 24.2.92; Buffer changing in dired-mark-pop-up

bug#13492: 24.2.92; Buffer changing in dired-mark-pop-up

[Leo Liu]

In discussion of http://debbugs.gnu.org/13152, it is noted that
dired-mark-pop-up invokes FUNCTION in different buffers depending on if
there are marked files. This is problematic and makes it harder to use
dired-mark-pop-up correctly.

In particular this is directly related to dired-guess-shell-alist-user,
a user variable. Harder to predict the behaviour of COMMAND when it is a
lisp expression. But in this case an error is thrown when the buffer is
switched to a non-dired buffer. So no user code will be broken if
dried-mark-pop-up stops switching buffers.

I propose fix dired-mark-pop-up to be consistent where it invokes
FUNCTION.

Leo

bug#13492: 24.2.92; Buffer changing in dired-mark-pop-up

[Lars Ingebrigtsen]

Leo Liu <sdl.web@gmail.com> writes:

> In discussion of http://debbugs.gnu.org/13152, it is noted that
> dired-mark-pop-up invokes FUNCTION in different buffers depending on if
> there are marked files. This is problematic and makes it harder to use
> dired-mark-pop-up correctly.
>
> In particular this is directly related to dired-guess-shell-alist-user,
> a user variable. Harder to predict the behaviour of COMMAND when it is a
> lisp expression. But in this case an error is thrown when the buffer is
> switched to a non-dired buffer. So no user code will be broken if
> dried-mark-pop-up stops switching buffers.
>
> I propose fix dired-mark-pop-up to be consistent where it invokes
> FUNCTION.

(This bug report unfortunately got no response at the time.)

I see that there's been some changes done to that function with regards
to how it selects windows before running FUNCTION, but I'm not sure
whether this fixes the problem or not, since there's no recipe to
reproduce the bug here.

Are you still seeing this problem in more recent versions of Emacs?  If
so, can you provide a step-by-step recipe to reproduce it, starting from
"emacs -Q"?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#13492: 24.2.92; Buffer changing in dired-mark-pop-up

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I see that there's been some changes done to that function with regards
> to how it selects windows before running FUNCTION, but I'm not sure
> whether this fixes the problem or not, since there's no recipe to
> reproduce the bug here.
>
> Are you still seeing this problem in more recent versions of Emacs?  If
> so, can you provide a step-by-step recipe to reproduce it, starting from
> "emacs -Q"?

More information was requested, but no response was given within a
month, so I'm closing this bug report.  If the problem still exists,
please respond to this email and we'll reopen the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no