From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Redisplay slower in Emacs 28 than Emacs 27 Date: Mon, 07 Dec 2020 22:59:24 +0100 Message-ID: <874kkx6zwj.fsf@gnus.org> References: <877dptiro7.fsf@gnus.org> <87pn3lhcdd.fsf@gnus.org> <878sa9hbe2.fsf@gnus.org> <877dptfvae.fsf@gnus.org> <83czzl8qwu.fsf@gnu.org> <87sg8h78s8.fsf@gnus.org> <87h7ox71xc.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20552"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 07 23:05:46 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmOdd-0005EH-HY for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Dec 2020 23:05:45 +0100 Original-Received: from localhost ([::1]:50230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmOdc-0007xF-Iw for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Dec 2020 17:05:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59834) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmOXi-0005vi-6B for emacs-devel@gnu.org; Mon, 07 Dec 2020 16:59:38 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:60596) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmOXg-0006lE-GG; Mon, 07 Dec 2020 16:59:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Z/oFYitj1f3DqJXyZpW6hBGfQwVEBIUE6BSnDAeD7kU=; b=c7u/1EvxkzUg4bQKuRDdVEIaS0 kf1u/jK/JDUHPJvjZ0K/nKUfMgYuM1cUEgX7kglacZ6oajUgzDQRUnxdKBbn7TYkdXM0zX9cbJe/N RAJqhrF1IGXdvKusMpy+URlCM65xReEDVppYHQPd1N88w68O50x45eDSO/qzIfpGRlA0=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmOXV-0002H4-Cj; Mon, 07 Dec 2020 22:59:32 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEX68O3TnqSnXHNA Jjz///9E1ZYgAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QMBxUcI0fbazgAAAGGSURBVDjLdZTrkYUw CIVBGwjYQCANrKH/3hYSkr3OdZnxh/lyDi9HAAAkOFpX+ArEcmjTAi/BpFRfgbzeBzj+I4iV3gFU eJU0EeSCHUeNhQomOOt9XHpa50rhSquro1i/9LJbBZGE1DaQQ4+zF+EAqm2BKgchCrgTAWtfYLTh WRFjBtzMYKZnf6tnFb+vShqAonx0U3OzAH7Hzz25kDsom4kSMV6qatYdFBbA5pd6p3DqLYjFmrhC iC0KuPwC4RU5WFnLGeBnnEvkbA5c6PIARuEx9sXNC1V7RM1xJ2gbSPYcHWRMw3sDS0W/20MxBd4D 0ZWKmNsDTCsiP97g9iVQZveBlgW69+lPVtFaIYjc3ccXU00zj8JDIZFAd/qYgUS540iHaikkRvIh 2FnYXKEDZCTQAPOcHwrfBz8EPGocO89j/SN9TA98zdtoVjen6mOkR6yKF2BNszZTfCvWNr/A6v0L 6Dv4+2YSRJfyOcXxic7qNdt4AN7gI/kCz/4mSEE87L+hAX4BNbZt41DXAP4AAAAldEVYdGRhdGU6 Y3JlYXRlADIwMjAtMTItMDdUMjE6Mjg6MzUrMDA6MDBLQm9pAAAAJXRFWHRkYXRlOm1vZGlmeQAy MDIwLTEyLTA3VDIxOjI4OjM1KzAwOjAwOh/X1QAAAABJRU5ErkJggg== X-Now-Playing: Throwing Muses's _Sun Racket_: "Sue's" In-Reply-To: (Gregory Heytings's message of "Mon, 07 Dec 2020 21:49:21 +0000") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260528 Archived-At: And this is the culprit -- i.e., this is what's busting the cache, as far as I can tell: (defun tool-bar--image-expression (icon) "Return an expression that evaluates to an image spec for ICON." (let* ((fg (face-attribute 'tool-bar :foreground)) (bg (face-attribute 'tool-bar :background)) (colors (nconc (if (eq fg 'unspecified) nil (list :foreground fg)) (if (eq bg 'unspecified) nil (list :background bg)))) (xpm-spec (list :type 'xpm :file (concat icon ".xpm"))) (xpm-lo-spec (list :type 'xpm :file (concat "low-color/" icon ".xpm"))) (pbm-spec (append (list :type 'pbm :file (concat icon ".pbm")) colors)) (xbm-spec (append (list :type 'xbm :file (concat icon ".xbm")) colors))) `(find-image (cond ((not (display-color-p)) ',(list pbm-spec xbm-spec xpm-lo-spec xpm-spec)) ((< (display-color-cells) 256) ',(list xpm-lo-spec xpm-spec pbm-spec xbm-spec)) (t ',(list xpm-spec pbm-spec xbm-spec)))))) Whenever Emacs is asked to redisplay the toolbar, Emacs will run this function? That's what my instrumentation seems to say... I don't use toolbars normally, so I'm not sure how they're supposed to work -- but shouldn't this toolbar data be computed only once, instead of repeatedly? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no