From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: Gnus using lexical-binding Date: Tue, 02 Feb 2021 10:17:54 -0800 Message-ID: <874kiu5o6l.fsf@ericabrahamsen.net> References: <86k0ruqub2.fsf@gmail.com> <86pn1mz4ni.fsf@gmail.com> <86wnvu80wp.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6685"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Andy Moreton , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 02 19:21:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l70IU-0001ZN-Lg for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Feb 2021 19:21:06 +0100 Original-Received: from localhost ([::1]:45066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l70IT-0001Gl-Kr for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Feb 2021 13:21:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l70Fd-00067B-Gs for emacs-devel@gnu.org; Tue, 02 Feb 2021 13:18:10 -0500 Original-Received: from ericabrahamsen.net ([52.70.2.18]:36506 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l70Fa-0001Oc-Bc for emacs-devel@gnu.org; Tue, 02 Feb 2021 13:18:09 -0500 Original-Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 4626BFA098; Tue, 2 Feb 2021 18:17:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1612289876; bh=j2NMAIoRtdShcw0ZaNZBCNj5+yWFU85Wet//4ktDkYo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=BdJ/bCvBLIhWAwAIZ6kiYMC4Cw9YcdtcGgj/cjEK7SPikUFN1ITE4Pslgez3e03J0 1ppXuChSh65eP9Zcb4GL7DAn1J97ov/cPdfOfVXeKOfYmF6QKH+3CPBrfuBFw4EW6Y knm2T8O59JxDrDK98C+KK53q+oSZYw+pYqNlBFa0= In-Reply-To: (Stefan Monnier's message of "Sat, 30 Jan 2021 19:06:08 -0500") Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263733 Archived-At: Stefan Monnier writes: >> Thats gets a little further, but... >> >> Debugger entered--Lisp error: (void-variable gnus-tmp-number-total) > > OK, I `defvar`d all the gnus-tmp-* I could find now. > Please try again. > > Note that the branch has a new name `scratch/lexical-gnus-rc` because > I have now cleaned up the commit messages, so it's basically "ready to > be merged". I'm now seeing a bug with `gnus-article-browse-html-article' that might (?) be a result of this, I'm not sure. Below is the definition of `gnus-visible-headers', which I haven't changed from its default. When viewing an HTML part, however, and we reach the function `article-hide-headers', the definition of `gnus-visible-headers' now looks like this: ((funcall #'#f(compiled-function () #))) Which `article-hide-headers' isn't set up to handle. Could this be a result of lexical binding? (defcustom gnus-visible-headers "^From:\\|^Newsgroups:\\|^Subject:\\|^Date:\\|^Followup-To:\\|^Reply-To:\\|^Organization:\\|^Summary:\\|^Keywords:\\|^To:\\|^[BGF]?Cc:\\|^Posted-To:\\|^Mail-Copies-To:\\|^Mail-Followup-To:\\|^Apparently-To:\\|^Gnus-Warning:\\|^Resent-From:" "All headers that do not match this regexp will be hidden. This variable can also be a list of regexp of headers to remain visible. If this variable is non-nil, `gnus-ignored-headers' will be ignored." :type '(choice (repeat :value-to-internal (lambda (widget value) (custom-split-regexp-maybe value)) :match (lambda (widget value) (or (stringp value) (widget-editable-list-match widget value))) regexp) (const :tag "Use gnus-ignored-headers" nil) regexp) :group 'gnus-article-hiding)