From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 760910f: Add a new buffer-local variable `minor-modes' Date: Sun, 14 Feb 2021 16:41:53 +0100 Message-ID: <874kieejwe.fsf@gnus.org> References: <20210214113754.21891.10736@vcs0.savannah.gnu.org> <20210214113756.93760209D4@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17834"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 14 16:43:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBJYb-0004Xh-D0 for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Feb 2021 16:43:33 +0100 Original-Received: from localhost ([::1]:46718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBJYa-0006HN-Cb for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Feb 2021 10:43:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBJXD-0005pQ-W7 for emacs-devel@gnu.org; Sun, 14 Feb 2021 10:42:09 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:50028) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBJX8-0007XS-Pe for emacs-devel@gnu.org; Sun, 14 Feb 2021 10:42:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=p/AEbzKwJAqlb2GrXdOfwXjKg81dT5B4YJv5MyvrfRU=; b=LuLJHFWJzZN12jSZvh6QLIdvL5 XM5G1J0vFhRZTOUTvZ+twAQieGJf4dk6dfSJbW4OO7S7LmLUoTXgWX+PSDQKUN3zf8hI6SjqnnC7A 8LlqAZKwzw9zpIDCIsQ4PsZcFn4l1bhjNouByIUoobxOC1KfkBYzTf00T6hQ3Q/OZX+c=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBJX0-0000ym-9D; Sun, 14 Feb 2021 16:41:58 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJ1BMVEVSU1NxcGs3Nzar qaDAvrPJx7r8+ejz79nX1sng3tB/fnWEgnz///9dx9TIAAAAAWJLR0QMgbNRYwAAAAd0SU1FB+UC Dg8jHyi/OWsAAAGlSURBVDjLlZJPT8IwGMYrxIsnJokHuRA+AaT+CfEIM3B2i9vRGDe4SYIt6lE2 2juj3dGPsHjky/muBSkwQnyWLG/32/N2e/oihJBVgRtq5Dd0YilBhbW6rlZXqYObKCjWE6I0oCC1 CgkluqAjRMJIkD1D+IEI/WoXAHAM8FUxeCnjAw63eqhVdSIWRaDReMbtIlApT1yPLfZA8Hn/Wi+h iz0QPvij+nlJA0p1DApMxPgys27Ui67ru6y3amVKCLHZwxTns2IwdxwvLgITJlXyeyCxU7MVHBAo rxLmpYZjyEBp/j2Jx2hgAs75enMniTeAcykZg1IqK90AljIOVTjv2nb3mgV096vWOgaGLF1t7jFu gvBv5KSU76So1dhxJDEdAq7ck0Su3X/UI6p/UHLOFIi8mTCABALxhVM/VomsAZdMqlglnwkDDCAI PT5zu89NBwCIaxGE0pdmq8Hq9+AEeWqCgNCdCT0aotPpTGP9ZBvgpoVv8+Lt+3QbtDINcOuMbIOW BlPcM8EwcjyW/ucEdwUDeMBBAVi1bLnE1lrVu1r2A8vKLyt9yo1PQS0gAAAAJXRFWHRkYXRlOmNy ZWF0ZQAyMDIxLTAyLTE0VDE1OjM1OjMwKzAwOjAwTfN7xAAAACV0RVh0ZGF0ZTptb2RpZnkAMjAy MS0wMi0xNFQxNTozNTozMCswMDowMDyuw3gAAAAASUVORK5CYII= X-Now-Playing: Portishead's _Glory Times (2)_: "Glory Box (Mudflap Mix)" In-Reply-To: (Stefan Monnier's message of "Sun, 14 Feb 2021 10:34:51 -0500") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:264710 Archived-At: Stefan Monnier writes: > Hmm... those files that have already been compiled with earlier Emacsen > will not keep this var up-to-date, so it can't be used reliably. > Also, I wonder why we need this to be a variable. Yes, the .elc files will have to be recompiled. > Can't we have an `enabled-minor-modes` function instead, which can simply > loop through `minor-mode-list` and see which ones are enabled? But how do we know which ones are enabled? As far as I know, there's no way to know (reliably) -- the :variable that shows whether the mode is on or not isn't preserved anywhere. Even if we had a function like that, looping over all possible minor modes and calling predicates for them sounds hopelessly slow when you have to do this for thousands of symbols... >> + ;; Keep `minor-modes' up to date. >> + (setq minor-modes (delq ',modefun minor-modes)) >> + (when ,getter >> + (push ',modefun minor-modes)) > > For global minor modes, this will adjust the list for the buffer that > happens to be current when the mode is changed, but it won't affect all > other buffers's lists. Oh, darn, didn't think about globalized minor modes... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no