From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#46509: 28.0.50; Unused static function in xfns.c with GTK2 Date: Mon, 15 Feb 2021 11:42:57 +0000 Message-ID: <874kidy2ta.fsf@tcd.ie> References: <87y2fqu616.fsf@tcd.ie> <83im6ubppx.fsf@gnu.org> <87a6s6tugy.fsf@tcd.ie> <87im6td752.fsf@tcd.ie> <874kidwrux.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37311"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46509@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 15 12:44:58 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBcJF-0009Z1-VT for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Feb 2021 12:44:58 +0100 Original-Received: from localhost ([::1]:46724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBcJE-0001IB-TW for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Feb 2021 06:44:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37222) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBcIM-0000tS-1c for bug-gnu-emacs@gnu.org; Mon, 15 Feb 2021 06:44:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54194) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBcIL-0008Me-RC for bug-gnu-emacs@gnu.org; Mon, 15 Feb 2021 06:44:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lBcIL-0003z6-OM for bug-gnu-emacs@gnu.org; Mon, 15 Feb 2021 06:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Feb 2021 11:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46509 X-GNU-PR-Package: emacs Original-Received: via spool by 46509-submit@debbugs.gnu.org id=B46509.161338938815247 (code B ref 46509); Mon, 15 Feb 2021 11:44:01 +0000 Original-Received: (at 46509) by debbugs.gnu.org; 15 Feb 2021 11:43:08 +0000 Original-Received: from localhost ([127.0.0.1]:37507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBcHU-0003xr-Hd for submit@debbugs.gnu.org; Mon, 15 Feb 2021 06:43:08 -0500 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:52189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBcHR-0003xJ-13 for 46509@debbugs.gnu.org; Mon, 15 Feb 2021 06:43:07 -0500 Original-Received: by mail-wm1-f53.google.com with SMTP id r5so2704332wmp.1 for <46509@debbugs.gnu.org>; Mon, 15 Feb 2021 03:43:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=s3hjdDx5kQZt5zOgHUU6fMfgXqhnCT//Dmfm1O0v7A4=; b=XbGIH9JbCJinypaQzUoppfbYzBEIEXxg8mxuLg4v5zGahYGEPpC4qFnbWaB2NXdV8I RblhYIcbxBfvgRRlodQSE1P5HaHJPeOkXLfV64/qfnudFADi9xhNBQ/zwBKs+jqKsl92 ZlhZbwtdcFIvOGjHh8mBtJ+K6fW31NgbSyo+UI+ommPD/SXrAB2AwGH1toIKNJPiRFFS TJGMlBV8GxIzzR+XMUpaBa6Av0TWYD12LHMsI7GsSkO7uOcJzVZ089xlO6csyJJ+YAHY 72/qm2UbyisYEoalRy1aMi3LhmlgAssy5oJ2Kyiw/LU4PP1cc1HUk7Ks5238gpq22gUb KjWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=s3hjdDx5kQZt5zOgHUU6fMfgXqhnCT//Dmfm1O0v7A4=; b=rzjo+HgQzIQPFT6a4BAWCR0vvGwUl2oaUIIG8FL0Brjwa148LFmkvenCR/M6pIKPnE sCvi/J4m0Sw+kUg9Vu7jP1SvM687eShBKcS/ZwHoqQo8RbvQ4HakXFRFIBbn+SNIHG69 FSLbSiomfI32vswD0mITnhjycagmU3Btld1IS49DTY08/eE35x9BI/ah6gVxUKnVlUci r8v8KbOP0fxD5RIQTQyG9YMqakAFxr/zwqhZD99TAY3jBwcakvtEA4xuWWyKBYkaGXPj H9tGHChWX5qXmv4x1DrKe6o1Xb/Ss7C29fnLHi+dRU2hMBqdKnJpQYhdWfsF6MyAKTte Dv8Q== X-Gm-Message-State: AOAM531X36FnxtwXES/01ueawW4vk5l2kZegZ6w7pk+FpZYVfOhG46fz kjOyLplm2p1NK7hZjwG69w0cYQ== X-Google-Smtp-Source: ABdhPJyEjg4AnUVl+FbMv05nqqFC2sN/cu771p6NX5lZPIH8PL1ZVxOlqBbkggBs2WY+EEimiDUm3g== X-Received: by 2002:a1c:4b05:: with SMTP id y5mr13887546wma.37.1613389379131; Mon, 15 Feb 2021 03:42:59 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id 35sm24658598wrn.42.2021.02.15.03.42.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 03:42:58 -0800 (PST) In-Reply-To: <874kidwrux.fsf@gmail.com> (Robert Pluim's message of "Mon, 15 Feb 2021 11:24:54 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200057 Archived-At: --=-=-= Content-Type: text/plain Robert Pluim writes: >>>>>> On Mon, 15 Feb 2021 11:05:59 +0100, martin rudalics said: > > >> What about this instead: > martin> Better. The ChangeLog is slightly excessive. > > And ChangeLog entries for changes depending on preprocessor directives > are supposed to put the directives in [ ], eg I know (although I forgot to indicate this for RANDR13_LIBRARY), but in this case the relevant directives are being changed, and I didn't know how best to indicate that. Here's the last commit in this area, for example: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-compilation-with-GTK-versions-older-than-3.patch >From 338154240e05a06a9fedb806940ef671868b4722 Mon Sep 17 00:00:00 2001 From: Eli Zaretskii Date: Wed, 1 Jan 2020 19:55:35 +0200 Subject: [PATCH] Fix compilation with GTK versions older than 3 * src/xfns.c (x_get_net_workarea): Change a recently moved #ifndef so that GTK builds which need this function will compile it. Reported by John . (cherry picked from commit d36adb544d984b91c70f6194da01344e4b2b6fc9) --- src/xfns.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xfns.c b/src/xfns.c index b94666d554..d0d5d399dc 100644 --- a/src/xfns.c +++ b/src/xfns.c @@ -4572,7 +4572,7 @@ DEFUN ("x-display-save-under", Fx_display_save_under, return Qnil; } -#ifndef USE_GTK +#if !defined USE_GTK || !defined HAVE_GTK3 /* Store the geometry of the workarea on display DPYINFO into *RECT. Return false if and only if the workarea information cannot be -- 2.30.0 --=-=-= Content-Type: text/plain I've come up with this: Pacify unused function warning in xfns.c with GTK2 * src/xfns.c (x_get_net_workarea, x_get_monitor_for_frame) (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback): [HAVE_XINERAMA] (x_get_monitor_attributes_xinerama) [HAVE_XRANDR] (x_get_monitor_attributes_xrandr) (x_get_monitor_attributes): Fix #ifdefs around definitions to avoid unused function warnings regardless of GTK use (bug#46509). [HAVE_XRANDR] (x_get_monitor_attributes_xrandr): Undefine RANDR13_LIBRARY after it's been used. But I'm not sure this pacifies Martin, so please suggest the best way of writing this. Thanks, -- Basil --=-=-=--