From: Juri Linkov <juri@linkov.net>
To: Daniel Mendler <mail@daniel-mendler.de>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [PATCH] `affixation-function`: Allow only three-element lists
Date: Tue, 27 Apr 2021 19:45:38 +0300 [thread overview]
Message-ID: <874kfrr80d.fsf@mail.linkov.net> (raw)
In-Reply-To: <f818d1b1-bd2f-89c6-3997-d60ba7ec2b0f@daniel-mendler.de> (Daniel Mendler's message of "Sun, 25 Apr 2021 23:04:15 +0200")
> Okay, fair enough. I am fine if the `cl-assert` is removed from the
> patch. The other changes should be kept though, such that we do not violate
> the more restricted specification. Other completion UIs may not support the
> two-element affixations which are then still accidentally allowed by the
> default completion UI. The `cl-assert` is just a cheap check to ensure that
> no violating affixation functions are accidentally reintroduced. But you
> are right that this is not fail-safe. Do you want me to send an updated
> patch with the `cl-assert` removed?
Your already sent patch is fine, thanks. I only removed `cl-assert`,
added a fix in the Info node "Programmed Completion", and pushed to master.
next prev parent reply other threads:[~2021-04-27 16:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 0:39 [PATCH] `affixation-function`: Allow only three-element lists Daniel Mendler
2021-04-25 17:46 ` Juri Linkov
2021-04-25 18:02 ` Daniel Mendler
2021-04-25 20:34 ` Juri Linkov
2021-04-25 21:04 ` Daniel Mendler
2021-04-27 16:45 ` Juri Linkov [this message]
2021-04-27 17:40 ` Daniel Mendler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kfrr80d.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=emacs-devel@gnu.org \
--cc=mail@daniel-mendler.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.