From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Wed, 26 May 2021 01:03:33 +0100 Message-ID: <874keqfjje.fsf@gmail.com> References: <87zgwlb4xc.fsf@gmail.com> <617d06ca-27bf-2ae8-26eb-1042123499d3@daniel-mendler.de> <87pmxhb1rs.fsf@gmail.com> <23510125-37b9-e87e-3590-5322f44772ce@daniel-mendler.de> <87a6olazff.fsf@gmail.com> <93d2cfe9-bae8-bf94-486f-7569aa31491d@daniel-mendler.de> <87bl8zivzj.fsf@gmail.com> <87o8czgqbw.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12316"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Daniel Mendler , emacs-devel@gnu.org, Stefan Monnier , Juri Linkov To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 26 02:05:19 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llh31-0002zp-Dl for ged-emacs-devel@m.gmane-mx.org; Wed, 26 May 2021 02:05:19 +0200 Original-Received: from localhost ([::1]:53856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llh30-0000X1-9t for ged-emacs-devel@m.gmane-mx.org; Tue, 25 May 2021 20:05:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llh1T-0008Hi-8h for emacs-devel@gnu.org; Tue, 25 May 2021 20:03:43 -0400 Original-Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:34427) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llh1O-0002zr-64 for emacs-devel@gnu.org; Tue, 25 May 2021 20:03:43 -0400 Original-Received: by mail-wr1-x436.google.com with SMTP id r12so33963059wrp.1 for ; Tue, 25 May 2021 17:03:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=wMzorntvBK1CY140qupddX4FlfHLbNARC9W6gSwZ3eI=; b=sakoKb7+2jiyo86W9s0kkGAmvYBoYzcCO5LknUVBLR4vJ3EOMtWil1CO6QdgYyPAhc h19lS8fZYebzPsfw/Cggn2W0iclDzFFJIYN4SesF+aQvblKq0hJ4KxfiCJhXX8ErBDt0 Cglb3Q9oikqo/zHcMT97+Ta+uqQ0hy+/+Q+n+AI/q+KWMZ0Hd1vEj1aCIX95ylVi35Vm dtx9hpd7PTG8/Q1SAl/VJcYutI1S0/oXJBiVqmpkABc1qgTTgal4klr7AEzI8MzuwGyX YCsgeRcw1ZSJD/XHTe1GPzOjSzN7/AS6FJ+V7wzWVJCI1TsY5DWIU445MtSMc7zqEu+2 qgZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=wMzorntvBK1CY140qupddX4FlfHLbNARC9W6gSwZ3eI=; b=QgPBVglJFidQjMVWW2FvLp7U7GVeRTJ0XEr4zmAXpo7LMJI4zBgc6IqENVk+y6P8u+ RhOCXMql0t6lTDpKPnwIiCy5VBsXgCIf/N9W4RfH8gPasFjpR311NBr9ZLCWPe3YDZW2 6XGYORy2Ghzu/DNFgQ409w+m9wM9SSYN8RG27b8e8vD2YjECFtgFbV42lvkfg8pd+F7w GfjlzV132MufzxS1oGAfAI0mPunoRmPQyMmg+J5SvVFurqvwjTysINORNlF2tuq5mXrg 9yYEVKSX9nkoIq4Rwy49tgO3nBtNhy6DcM+mhaMxYgNXIToH5LRVxDtbZ+Q0QgGdEfwQ sKMQ== X-Gm-Message-State: AOAM531MKmYxVoLwN2O+xcHJRrnU04qE1AnA+zX3P0CcVg+oYfjI4yFV NPAVJL01lTS1VKlapD/Xa1EN7fsI85E= X-Google-Smtp-Source: ABdhPJw/G8ALaYaz4F18IHFTqtMen4U51w9MKd2UyrGiyktzx0KNMpikvtywmkSl6jPk8DVBmgUJTg== X-Received: by 2002:adf:f9d0:: with SMTP id w16mr30606026wrr.336.1621987416334; Tue, 25 May 2021 17:03:36 -0700 (PDT) Original-Received: from krug (a94-133-55-152.cpe.netcabo.pt. [94.133.55.152]) by smtp.gmail.com with ESMTPSA id u126sm5207276wmb.9.2021.05.25.17.03.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 17:03:35 -0700 (PDT) In-Reply-To: (Gregory Heytings's message of "Tue, 25 May 2021 11:00:12 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=joaotavora@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269904 Archived-At: Gregory Heytings writes: > Hi Daniel and Jo=C3=A3o, > > I said in bug#48013 that I was working on this, but I was waiting for > my copyright assignment to complete before sending patches. Anyway, > apparently you've now taken this over, which is fine. Alas I have no > time to look at what you did to send useful comments this week. > > Gregory I've done a bit more work on icomplete.el and after seeing the discussion evolve, I agree with Daniel that it's better to keep those two things orthogonal. So I've now published two branches: - scratch/icomplete-vertical-mode-improvements This makes icomplete-vertical-mode much nicer IMO. After removing the rotation in the vertical mode and adding a highlight color it looks a bit like Vertico (which I tried recently). If people like the rotation in vertical mode, too, it's very easy to get it back. It also adds the annotation capabilities using some of the code Daniel originally submitted. Since you, Gregory, made icomplete-vertical-mode and you, Daniel, worked on its annotation capabilities, I wish you'd both have a look. Else I will test it for a few days and then push to master. There are still a lot of edges to polish, and I may have introduced some bugs, though hopefully not in the legacy non-vertical parts. - scratch/annotation-function-improvements This overhauls annotation-function and makes the C-h f and M-x backends use it instead of affixation-function. It doesn't delete affixation-function. It _may_ be useful, but I guess it's not the end of the affixation-function thing anyway, and I don't any much more to contribute at this point. Jo=C3=A3o