From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#48071: 28.0.50: dired-guess-default: comply with docstring options [PATCH] Date: Tue, 20 Jul 2021 16:17:39 +0200 Message-ID: <874kcpdq7w.fsf@gnus.org> References: <20210427185340.e4zluvf3z5ywbpqn@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4415"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 48071@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 20 16:18:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5qZV-0000xk-OQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Jul 2021 16:18:09 +0200 Original-Received: from localhost ([::1]:56464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5qZU-0001tK-Nn for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Jul 2021 10:18:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39064) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5qZO-0001sG-Aj for bug-gnu-emacs@gnu.org; Tue, 20 Jul 2021 10:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51682) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5qZO-0008Q4-34 for bug-gnu-emacs@gnu.org; Tue, 20 Jul 2021 10:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m5qZO-0002l9-0L for bug-gnu-emacs@gnu.org; Tue, 20 Jul 2021 10:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Jul 2021 14:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48071-submit@debbugs.gnu.org id=B48071.162679067110575 (code B ref 48071); Tue, 20 Jul 2021 14:18:01 +0000 Original-Received: (at 48071) by debbugs.gnu.org; 20 Jul 2021 14:17:51 +0000 Original-Received: from localhost ([127.0.0.1]:34992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5qZD-0002kV-Id for submit@debbugs.gnu.org; Tue, 20 Jul 2021 10:17:51 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:58064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5qZB-0002k8-7S for 48071@debbugs.gnu.org; Tue, 20 Jul 2021 10:17:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VwC1sfEMZ5aEsVk6ZGrbOqC4mAUna3ZHgHp1/LErQvI=; b=UZVVbYOLit4lOAINQBpj+5GeI+ lf+Yxi0xTe1U3DuETR6LKhOUpRzfSUCEbO4SaOEnmq+lqe6Ebgrd3Yn0lVY66xoT/tzZTaGxapI8d Dy1ei4GrZ3IDaJGNOkAcbWvP1oKc4M77+IzuABdoFq0EhZC+GAcl7oVsHr5iBS/PZqEE=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5qZ2-00044K-6w; Tue, 20 Jul 2021 16:17:42 +0200 X-Now-Playing: 214's _Fabric 94: Steffi_: "Sound Moments" In-Reply-To: <20210427185340.e4zluvf3z5ywbpqn@E15-2016.optimum.net> (Boruch Baum's message of "Tue, 27 Apr 2021 14:53:40 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210357 Archived-At: Boruch Baum writes: > The docstring for dired-guess-default claims it should handle multiple > instances of COMMAND each of which could be a STRING or a FUNCTION which > evaluates to a STRING ... > > The attached patch does that. It also weeds out strings that don't represent > valid programs on the host machine. I don't think we want to do the latter because of Tramp considerations. I've now changed dired-guess-default in a somewhat different way than your patch suggested, but it's functionally similar. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no