all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 50038@debbugs.gnu.org
Subject: bug#50038: Permanent shift-select-mode
Date: Sun, 15 Aug 2021 11:37:48 +0300	[thread overview]
Message-ID: <874kbrciwz.fsf@mail.linkov.net> (raw)
In-Reply-To: <83lf54bkft.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Aug 2021 09:37:58 +0300")

[-- Attachment #1: Type: text/plain, Size: 1696 bytes --]

>> +When the value is `permanent', the mark will not be deactivated
>> +by any subsequent point motion key that was not shift-translated.
>
> This is a negative description, which tells half of the story, and
> leaves it to the reader to guess the other half (how to deactivate the
> mark in this case).  How about describing both, and in a positive way?
> For example:
>
>   When the value is `permanent', the mark will be deactivated by any
>   action which normally does that, but not by motion keys that were
>   not shift-translated.

Fixed in the new patch.

> And finally, a question: is it enough to have this as a user option?
> That is, what if the user wants this only temporarily, for the next
> sequence of commands that extend the region?  Should we perhaps have a
> better solution for that use case?  More generally, perhaps this
> feature is almost always wanted only for a sequence of commands, never
> globally for extended periods of time?  In that case, a user option is
> not the best solution; it is better to have some minor mode that could
> be turned on and off with a simple key sequence.

It would be very surprising if someone might want something more complicated.
But everyone is welcome to extend this feature when such a need will arise.

>>  See `this-command-keys-shift-translated' for the meaning of
>>  shift-translation."
>> -  :type 'boolean
>> +  :type '(choice (const :tag "Off" nil)
>> +                 (const :tag "Permanent" permanent)
>> +                 (other :tag "On" t))
>> +  :version "28.1"
>>    :group 'editing-basics)
>
> This would also need a NEWS entry, if we eventually decide to do it
> this way.

This patch also adds a NEWS entry:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: shift-select-mode-permanent-2.patch --]
[-- Type: text/x-diff, Size: 2143 bytes --]

diff --git a/etc/NEWS b/etc/NEWS
index 09ace73f5d..37acef0be1 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -263,6 +263,12 @@ This works in text buffers and over images.  Typing a numeric prefix arg
 (e.g. 'M-5') before starting horizontal scrolling changes its step value.
 The value is saved in the user option 'mouse-wheel-scroll-amount-horizontal'.
 
+---
+** New choice 'permanent' for 'shift-select-mode'.
+When the mark was activated by shifted motion keys,
+non-shifted motion keys don't deactivate the mark
+after customizing 'shift-select-mode' to 'permanent'.
+
 ---
 ** The default value of 'frame-title-format' and 'icon-title-format' has changed.
 These variables are used to display the title bar of visible frames
diff --git a/lisp/simple.el b/lisp/simple.el
index 985beb06fc..960422a6b2 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -6649,9 +6649,16 @@ shift-select-mode
 by any subsequent point motion key that was not shift-translated, or
 by any action that normally deactivates the mark in Transient Mark mode.
 
+When the value is `permanent', the mark will be deactivated by any
+action which normally does that, but not by motion keys that were
+not shift-translated.
+
 See `this-command-keys-shift-translated' for the meaning of
 shift-translation."
-  :type 'boolean
+  :type '(choice (const :tag "Off" nil)
+                 (const :tag "Permanent" permanent)
+                 (other :tag "On" t))
+  :version "28.1"
   :group 'editing-basics)
 
 (defun handle-shift-selection ()
@@ -6669,7 +6676,12 @@ handle-shift-selection
 Otherwise, if the region has been activated temporarily,
 deactivate it, and restore the variable `transient-mark-mode' to
 its earlier value."
-  (cond ((and shift-select-mode this-command-keys-shift-translated)
+  (cond ((and (eq shift-select-mode 'permanent)
+              this-command-keys-shift-translated)
+         (unless mark-active
+           (push-mark nil nil t)))
+        ((and shift-select-mode
+              this-command-keys-shift-translated)
          (unless (and mark-active
 		      (eq (car-safe transient-mark-mode) 'only))
 	   (setq-local transient-mark-mode

  reply	other threads:[~2021-08-15  8:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13  7:04 bug#50038: Permanent shift-select-mode Juri Linkov
2021-08-13 12:06 ` Lars Ingebrigtsen
2021-08-14  6:37 ` Eli Zaretskii
2021-08-15  8:37   ` Juri Linkov [this message]
2021-08-15  9:36     ` Eli Zaretskii
2021-08-15 16:19       ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kbrciwz.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=50038@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.